Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Editor: 40vh padding applied to the bottom is overwritten with zero #63278

Closed
t-hamano opened this issue Jul 9, 2024 · 1 comment · Fixed by #63288
Closed

Post Editor: 40vh padding applied to the bottom is overwritten with zero #63278

t-hamano opened this issue Jul 9, 2024 · 1 comment · Fixed by #63288
Assignees
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jul 9, 2024

Description

In WP6.6, when useRootPaddingAwareAlignments is false in theme.json, the expected 40vh padding below the content in the post editor is overwritten with zero.

This makes it difficult to click below the content and insert a new block.

I think the issue is related to the CSS selector that applies the zero padding changing from body to :root :where(body), which has a higher specificity.

WP6.5

✅ useRootPaddingAwareAlignments: true

image

✅ useRootPaddingAwareAlignments: false

image

WP6.6

✅ useRootPaddingAwareAlignments: true

image

❌ useRootPaddingAwareAlignments: false

override-padding

Step-by-step reproduction instructions

  • Define the theme.json for your block theme as follows:
    {
    	"version": 2,
    	"settings": {
    		"layout": {
    			"contentSize": "620px",
    			"wideSize": "1280px"
    		}
    	}
    }
  • Open the post editor and insert some content.
  • Scroll to the very bottom of the content.
  • There will be no padding below the content.

Screenshots, screen recording, code snippet

Actual

actual

Expected

expected

Environment info

WordPress 6.6 RC2 and latest Gutenberg plugin

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Jul 9, 2024
@t-hamano t-hamano changed the title Post Editor: The 40vh padding applied to the bottom is overwritten with zero Jul 9, 2024
@talldan
Copy link
Contributor

talldan commented Jul 9, 2024

I don't know much about useRootPaddingAwareAlignments. 🤔

I guess the 40vh rule should be bumped to 0,1,0 specificity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
3 participants