Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid flex-direction *-reverse values in native files #63092

Open
afercia opened this issue Jul 3, 2024 · 0 comments
Open

Avoid flex-direction *-reverse values in native files #63092

afercia opened this issue Jul 3, 2024 · 0 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 3, 2024

Description

Splitting this out from #63081

#63081 adds a new Stylelint custom rule to prevent the usage of the flex-direction CSS property values row-reverse and column-reverse values.

For more details about why this is a problem for accessibility and the very limited cases where these values can be used, please see #63048 and #61241

Contributors working on the native files may want to consider to refactor a few components where row-reverse and column-reverse are currently in use:

  • 1 occurrence in packages/block-editor/src/hooks/use-editor-wrapper-styles.native.scss
  • 2 occurrences in packages/block-library/src/media-text/style.native.scss

For mow, #63081 adds Stylelint disable comments. However, if the current implementation actually alters the order in a way that impacts meaning and interaction, it should be refactored.

Cc @WordPress/native-mobile

Step-by-step reproduction instructions

N/A

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
1 participant