Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate existing blocks to experimental form framework #62904

Open
carlomanf opened this issue Jun 27, 2024 · 1 comment
Open

Migrate existing blocks to experimental form framework #62904

carlomanf opened this issue Jun 27, 2024 · 1 comment
Labels
Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.

Comments

@carlomanf
Copy link

carlomanf commented Jun 27, 2024

What problem does this address?

Core blocks like login form, comment form and search form offer very little customisability. For example, changing the button text from "Post Comment" to "Add Comment" or disabling the website field is impossible without using filters.

What is your proposed solution?

Re-fashion the comment form, login form and search form blocks as variations of the experimental form block. For example, removing the website field from the comment form could be as simple as deleting the relevant input block from the form, and changing the button text could be as simple as clicking and typing.

The experimental form suite still has a way to go before being viable for such a purpose. Most notably, the ability to transform between form variations via the inspector is of questionable value. If a user is customising their comment form, they would just be confused to see an option to transform it to a privacy request form. The embed block does not let you transform between variations, so why should the form block let you?

Similarly, being able to change the submissions method is likely to cause too much confusion and unintended destruction. It does not make any sense that a user should be able to submit their comment form or especially their login form by GET method. The form variations should be "siloed" such that once a variation is selected, the technical specifications are locked in and the form can only be used for the originally selected purpose.

There are other minor bugs with the experimental form suite that need to be addressed before it can be moved out of experimental status. Another one I noticed is that the form block is not able to be selected if inside a group block.

Unfortunately there has been very little attention on the experimental form suite since its initial merge and even more so since the original author retired from contributing to this repository. History has shown that stale features start getting more attention once they become dependencies for something else, which is why I think it is time for pre-existing core features like login form, comment form and search form to be migrated to this framework.

@carlomanf carlomanf added the [Type] Enhancement A suggestion for improvement. label Jun 27, 2024
@carlomanf carlomanf changed the title Migrate login form and comment form to experimental form framework Jun 27, 2024
@skorasaurus skorasaurus added the Needs Decision Needs a decision to be actionable or relevant label Jun 27, 2024
@carlomanf
Copy link
Author

Not sure of the logistics of this, but it would be ideal if these blocks could be migrated within the forms experiment only and left unchanged outside of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.
2 participants