Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lock modal description and options naming #62843

Open
afercia opened this issue Jun 25, 2024 · 1 comment
Open

Improve Lock modal description and options naming #62843

afercia opened this issue Jun 25, 2024 · 1 comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jun 25, 2024

Description

Splitting this out from #62795

The description of the Lock modal dialog and the naming of hte various options could use some more clear wording.

Screenshot:

Screenshot 2024-06-25 at 15 55 20

1
The description: Choose specific attributes to restrict or lock all available options.

Note: after #62795 the description will become the <legend> element of the form fieldset, thus it will be used to give the fieldset group a name.

Issues:

  • The text is too long. It would benefit from being more concise.
  • Visually, the checkboxes order is: 'Lock all' first, the other options after. However, the current description first mentions the other options, and then the ability to lock all. As such, when reading the description, there is a logical mismatch with the visuals that doesn't help with immediately understanding the interface.
  • As a user, I have no clue what the difference between 'attributes' and 'options' is. I'm not sure introducing these two concepts helps with understanding the UI. I'd rather propose to simplify. Users just want to lock either all or some features.

2
The options naming.
The specific 'options' use three different verbs:

  • Restrict
  • Disable
  • Prevent

While, technically, they may be the most correct verbs to use, I'd argue that by using different verbs this UI adds unnecessary cognitive load. As a user, my experience would be:

  • Click on a menu item called 'Lock'.
  • A modal dialog named 'Lock {block name}' opens.
  • The first option I see is named 'Lock all'.
  • But, suddenly, the following options are Restrict / Disable / Prevent.
  • At this point, I may wonder what the difference is between Lock / Restrict / Disable / Prevent, if any, and get a little confused.

I'd like to propose to drastically simplify. This is a feture to 'lock things'. How about:

  • Lock all
    • Lock editing
    • Lock movement
    • Lock removal

Step-by-step reproduction instructions

  • To see all the available options in the Lock modal dialog, add a Navigation block.
  • Select the Navigation block and from its toolbar choose Options > Lock.
  • Observe the wording of the description and of the options.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor labels Jun 25, 2024
@mtias
Copy link
Member

mtias commented Jul 1, 2024

This panel will also absorb content-only locking, so a thorough review of all the copy should take that into account. The whole set of access control properties and how to best communicate it to people. It can get complex fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor [Type] Bug An existing feature does not function as intended
2 participants