Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Editor: ⌘+a shortcut closes the renaming modal and changes focus #62831

Closed
priethor opened this issue Jun 25, 2024 · 3 comments
Closed
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended

Comments

@priethor
Copy link
Contributor

Description

When renaming a block in the post editor, the ⌘+a shortcut closes the renaming modal; instead of selecting the text, it selects all the blocks on the canvas.

This only happens when editing a post/page, not on the site editor.

Step-by-step reproduction instructions

  1. Go to edit a post or page
  2. Open the List View
  3. Click on the ellipsis points and select Rename
  4. Hit ⌘+a to select all the text; it will close the modal and select all the blocks on the canvas instead

Screenshots, screen recording, code snippet

microsite

This is how it's supposed to work, as seen on the site editor:
rename command a

Props to @jasmussen for finding the bug and sharing the gifs.

Environment info

  • WordPress 6.5.5, Gutenberg trunk (18.6.1)
  • Checked on MacOs, to be confirmed if it happens in Windows/Linux with Control+a

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@priethor priethor added the [Type] Bug An existing feature does not function as intended label Jun 25, 2024
@Mamaduka
Copy link
Member

I'm pretty sure @t-hamano fixed this bug in #62479.

@Mamaduka Mamaduka added the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label Jun 26, 2024
@jasmussen
Copy link
Contributor

That would explain why I've been able to reproduce it in some cases, but not others.

@Mamaduka
Copy link
Member

Let's close this. I can't reproduce the issue on the trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended
3 participants