Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global Styles: Active variation not shown when using block variations #62758

Closed
scruffian opened this issue Jun 21, 2024 · 1 comment
Closed

Global Styles: Active variation not shown when using block variations #62758

scruffian opened this issue Jun 21, 2024 · 1 comment
Assignees
@scruffian
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@scruffian
Copy link
Contributor

What problem does this address?

If style variations contain block variations then the UI doesn't recognise which style variation is active, for example, using the Assembler theme, with the blueberry variation active, but not shown as active in the UI
Screenshot 2024-06-21 at 18 33 11

What is your proposed solution?

We need to update areGlobalStyleConfigsEqual so that it is aware of block variations and can correctly compare the current user settings with a style variation.
@scruffian scruffian added the [Type] Bug An existing feature does not function as intended label Jun 21, 2024
@annezazu annezazu added [Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 21, 2024
@scruffian scruffian mentioned this issue Jun 24, 2024
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 24, 2024
@aaronrobertshaw
Copy link
Contributor

I haven't been able to replicate this issue using Gutenberg trunk. I think we might be able to close it.

More details in this review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
3 participants
@scruffian @annezazu @aaronrobertshaw