Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text alignment controls in global styles for irrelevant blocks #62369

Closed
richtabor opened this issue Jun 6, 2024 · 1 comment · Fixed by #62376
Closed

Text alignment controls in global styles for irrelevant blocks #62369

richtabor opened this issue Jun 6, 2024 · 1 comment · Fixed by #62376
Assignees
@t-hamano
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

richtabor commented Jun 6, 2024 •
edited
Loading

Description

The new text alignment controls are available in global styles for blocks that do not support typography. These should be constrained to blocks that support typography, rather than added to every block.

Notably (but there are certainly others):

  • Template part block
  • HTML block
  • Embed block
  • Page list item
  • Pattern placeholder
  • More
  • Page break

Step-by-step reproduction instructions

  1. Open the Site Editor.
  2. Select global styles.
  3. Select "Blocks"
  4. Select "Template part" (then repeat with HTML block).
  5. See bug.

Screenshots, screen recording, code snippet

CleanShot 2024-06-06 at 09 28 41
CleanShot 2024-06-06 at 09 32 03

Environment info

WordPress trunk
Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@richtabor richtabor added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Jun 6, 2024
@richtabor richtabor changed the title Template parts should not have text alignment styles Jun 6, 2024
@t-hamano
Copy link
Contributor

t-hamano commented Jun 6, 2024

I've found the cause and will submit a PR shortly.
@t-hamano t-hamano self-assigned this Jun 6, 2024
@t-hamano t-hamano mentioned this issue Jun 6, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants
@richtabor @t-hamano