Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Editor Document Sidebar Publish Date causes horizontal overflow #62215

Closed
fabiankaegy opened this issue Jun 3, 2024 · 6 comments · Fixed by #62233
Closed

Post Editor Document Sidebar Publish Date causes horizontal overflow #62215

fabiankaegy opened this issue Jun 3, 2024 · 6 comments · Fixed by #62233
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release

Comments

@fabiankaegy
Copy link
Member

I just noticed whilst testing Gutenberg version 18.5 RC1 that the Publish date control causes a horizontal scroll bar to appear in the document settings sidebar in the post editor.
CleanShot 2024-06-03 at 07 43 55@2x

@fabiankaegy fabiankaegy added [Type] Regression Related to a regression in the latest release Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) labels Jun 3, 2024
@fabiankaegy
Copy link
Member Author

CC: @jameskoster as I believe I saw you were involved in the redesign work here :)

@t-hamano
Copy link
Contributor

t-hamano commented Jun 3, 2024

This is strange because this button has text-wrap: pretty; applied to it, so the text should wrap. And this style was added in #61954, which is part of Gutenberg 18.5.

image

  • Do you have text-wrap: pretty; applied to that button?
  • Do you have this problem with the latest Gutenberg?
@fabiankaegy
Copy link
Member Author

@t-hamano safari doesn't support text wrap pretty. It only supports balance at this point

@t-hamano
Copy link
Contributor

t-hamano commented Jun 3, 2024

safari doesn't support text wrap pretty

I see, that's certainly true.

@WordPress/gutenberg-design To prevent text overflow in Safari, it may be better to use something like white-space: normal instead of text-wrap: pretty for this panel only. Of course, the text wrapping position will change.

@jasmussen
Copy link
Contributor

Can we do this?

text-wrap: balance;
text-wrap: pretty;

Presumably, that would cause Safari to fall back to balance if pretty isn't available.

@fabiankaegy
Copy link
Member Author

@jasmussen Yeah that is how I commonly do it :) With a little comment explaining why the fallback is there =D

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 3, 2024
@vcanales vcanales removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Regression Related to a regression in the latest release
4 participants