Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser: applyBlockValidation revalidating original block instead of fixed #62176

Closed
tjcafferkey opened this issue May 31, 2024 · 1 comment · Fixed by #62178
Closed

Parser: applyBlockValidation revalidating original block instead of fixed #62176

tjcafferkey opened this issue May 31, 2024 · 1 comment · Fixed by #62178
Assignees
Labels
[Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@tjcafferkey
Copy link
Contributor

When initially parsing and loading blocks we attempt to validate their parsed attributes and apply auto-fixes when invalid, before attempting to validate again after the fixes have been applied. This is done after we get a new raw block back after a round of fix attempts, which we can revalidate.

However, looking at this section of code it appears as though we are revalidating the original unvalidatedBlock instead of fixedBlock during the second execution of validateBlock().

It looks to me like on the second run of validateBlock(), we should be passing fixedBlock as the first param instead.

@tjcafferkey tjcafferkey added [Type] Bug An existing feature does not function as intended [Feature] Block API API that allows to express the block paradigm. labels May 31, 2024
@Mamaduka
Copy link
Member

It's probably a regression after #37763. cc @dmsnell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants