Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Unwanted top margin added to the first block inside flow layout container #62148

Closed
iamtakashi opened this issue May 30, 2024 · 1 comment · Fixed by #62159
Closed
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@iamtakashi
Copy link

Description

This must have been introduced recently. It only happens when the Gutenberg plugin is activated and seems to happen only in the site editor.

Usually, when the layout is constrained, the top margin is removed from the first block in a container.

CleanShot 2024-05-30 at 16 03 19@2x

However, if the container has the flow layout, the top margin doesn't get removed.

CleanShot 2024-05-30 at 16 06 51@2x

Step-by-step reproduction instructions

  1. Open the site editor
  2. Add a group block
  3. Add a block in the group block
  4. Set the layout of the group block to flow(unconstrained).
  5. See the gap between the container and the first block in it.

Screenshots, screen recording, code snippet

No response

Environment info

  • WP 6.5.3
  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@iamtakashi iamtakashi added the [Type] Bug An existing feature does not function as intended label May 30, 2024
@iamtakashi iamtakashi changed the title Unwanted top margin added to the first block inside flow layout container May 30, 2024
@tellthemachines
Copy link
Contributor

tellthemachines commented May 30, 2024

Hmm, looks like there's an extra curly bracket being output in the global styles for the site editor:

Screenshot 2024-05-31 at 9 54 48 AM

Edit: yeah this was introduced by #60715. I'll put up a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants