Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments Pagination: Remove unwanted bottom margin from links #62114

Open
iamtakashi opened this issue May 29, 2024 · 2 comments
Open

Comments Pagination: Remove unwanted bottom margin from links #62114

iamtakashi opened this issue May 29, 2024 · 2 comments
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.

Comments

@iamtakashi
Copy link

Similar to #51299, the Comments Next Page, Comments Previous Page, and Comments Page Numbers blocks have unwanted bottom margins. I don't see why we need them, and they are creating misalignments in themes.

CleanShot 2024-05-29 at 18 26 31@2x

We can't get rid of it in Global Styles in the editor, we can't get rid of it in the theme.json, and the custom CSS is getting overridden by default as well.

CleanShot 2024-05-29 at 18 29 36@2x

Can we just remove the default bottom margin for all three blocks?

@iamtakashi iamtakashi added the [Type] Enhancement A suggestion for improvement. label May 29, 2024
@t-hamano
Copy link
Contributor

This margin appears to have been there since the block itself was added: #36872

@cbravobernal If you know why this margin was necessary, I would appreciate it if you could tell us 🙏

@cbravobernal
Copy link
Contributor

To be honest I do not remember. I guess I copied the styles that were on the non-block version.

@jordesign jordesign added the [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Type] Enhancement A suggestion for improvement.
4 participants