Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow selection from block settings adds value instead of variable reference in template #61984

Closed
madhusudhand opened this issue May 25, 2024 · 1 comment
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Type] Bug An existing feature does not function as intended

Comments

@madhusudhand
Copy link
Contributor

Description

Applying a shadow to a block from block settings adds a direct shadow value in the template.

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button {"backgroundColor":"vivid-green-cyan","style":{"shadow":"6px 6px 9px rgba(0, 0, 0, 0.2)"}} -->
<div class="wp-block-button"><a class="wp-block-button__link has-vivid-green-cyan-background-color has-background wp-element-button" style="box-shadow:6px 6px 9px rgba(0, 0, 0, 0.2)">Button 1</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

Expectation: it should add the corresponding css variable in the template.

Step-by-step reproduction instructions

  1. Edit any template, post or a page.
  2. Add a button block
  3. From block settings apply a core shadow (ex: natural)
  4. Observe that the direct value is added in the template.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@madhusudhand madhusudhand added [Type] Bug An existing feature does not function as intended [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks labels May 25, 2024
@madhusudhand
Copy link
Contributor Author

It's is no longer issue with Gutenberg trunk. Closing invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Type] Bug An existing feature does not function as intended
1 participant