Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic block: TinyMCE tooltips are not displayed on focus #6193

Closed
afercia opened this issue Apr 16, 2018 · 4 comments
Closed

Classic block: TinyMCE tooltips are not displayed on focus #6193

afercia opened this issue Apr 16, 2018 · 4 comments
Assignees
Labels
[Block] Classic Affects the Classic Editor Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Apr 16, 2018

TinyMCE displays its own tooltips for its buttons just on mouseover, see https://github.com/tinymce/tinymce/blob/6b1c354e63ef0c01314b44a7c7115c433a1b8fb3/src/core/src/main/js/ui/Widget.js#L46

However, in Gutenberg, all controls including the blocks formatting toolbars display their tooltips also on focus. That's for good accessibility reasons, as the accessible name of an UI control must be exposed and discoverable, at least with a tooltip, also for keyboard users.

Aside: the Classic block toolbar at the moment is not accessible with a keyboard, see #6118 / #6163

For consistency and accessibility reasons I'd strongly recommend to make the TinyMCE tooltips appear also on focus. Not sure if this would be better handled upstream or if there's a way to override some TInyMCE behaviors. /Cc @azaozz @iseulde

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Component] TinyMCE labels Apr 16, 2018
@afercia
Copy link
Contributor Author

afercia commented Sep 10, 2018

Re-tested during today's accessibility bug-scrub and still a problem on current master (well, no surprise as it seems to be a TinyMCE thing). Ping @azaozz @iseulde 🙂

@ellatrix ellatrix added [Block] Classic Affects the Classic Editor Block and removed [Component] TinyMCE labels Oct 31, 2018
@afercia
Copy link
Contributor Author

afercia commented Feb 16, 2019

Looking into pending issues, just tested again and this is still a problem to address. Noting this issue was opened 11 months ago. @azaozz @iseulde do you think this should be addressed upstream or maybe there's a way to patch it? Thanks!

@joedolson joedolson self-assigned this Jun 2, 2023
@joedolson
Copy link
Contributor

Issue on TinyMCE: tinymce/tinymce#6342

From a conversation with @azaozz, he's looked into this and there's no way to fix this outside of TinyMCE. TinyMCE has had this open for a few years, and has not progressed on it; they've switched to native title attributes in TinyMCE 6.

Unless somebody is willing to push this through in TinyMCE, I'm not sure that this is realistically going to happen.

@youknowriad
Copy link
Contributor

The upstream issue has been closed as stale and given there's nothing that can be done in Gutenberg for this, I think we should just close the current issue as won't fix

@youknowriad youknowriad closed this as not planned Won't fix, can't repro, duplicate, stale Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Classic Affects the Classic Editor Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
4 participants