Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black border around the navigation items when sub items are present #59944

Open
tomxygen opened this issue Mar 18, 2024 · 8 comments
Open

Black border around the navigation items when sub items are present #59944

tomxygen opened this issue Mar 18, 2024 · 8 comments
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@tomxygen
Copy link

Description

When a sub-menu item is present, when clicking on the sub-menu item or on the parent menu item, a black border is shown around the items.
See the screen recording attached.

Step-by-step reproduction instructions

  1. go to the site editor
  2. add a navigation block
  3. add an item and a sub item
  4. publish changes and visit the site
  5. click on the sub-menu item and on the parent item
  6. see the black border as in the screen recording attached.

Screenshots, screen recording, code snippet

Screen.Recording.2024-03-18.at.9.26.17.AM.mov

Environment info

  • WordPress 6.5 RC2
  • 2024 theme

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@tomxygen tomxygen added the [Type] Bug An existing feature does not function as intended label Mar 18, 2024
@annezazu
Copy link
Contributor

I could replicate with RC2. @getdave can you look into this? Here's what I saw:

Screen.Recording.2024-03-18.at.8.54.40.AM.mov

Adding to triage for now.
@getdave getdave added [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Mar 18, 2024
@getdave
Copy link
Contributor

getdave commented Mar 18, 2024

I could replicate with RC2. @getdave can you look into this? Here's what I saw:

Adding to my todos for tomorrow.
@getdave
Copy link
Contributor

getdave commented Mar 19, 2024 •
edited
Loading

Screen Shot 2024-03-19 at 10 23 43

I've confirmed this issue and I can see the selector that is causing it. I'm now going to track down where that came from.

This seems to come from the Theme. In this case it's TT4. I tested with TT3 and the issue is not in evidence,

What is more, the issue applies to any link that gains focus not just in the Nav block.

As a result I'm removing the Nav block specific labels.
@getdave
Copy link
Contributor

getdave commented Mar 19, 2024

@MaggieCabrera This seems like it could be TT4 specific. Are you able to offer any insight here?
@getdave getdave removed [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Mar 19, 2024
@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Mar 19, 2024 •
edited
Loading

@MaggieCabrera This seems like it could be TT4 specific. Are you able to offer any insight here?

I think it comes from https://core.trac.wordpress.org/changeset/57739 This probably requires a theme specific trac ticket, rather than a Gutenberg issue
@getdave
Copy link
Contributor

getdave commented Mar 19, 2024

Thanks @MaggieCabrera. I'm going to remove this from the WP 6.5 board as it's not 6.5 specific.

However we should look to resolve in TT4.
@annezazu
Copy link
Contributor

Thank you all for sleuthing this!
@jordesign jordesign added [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Mar 20, 2024
@jordesign
Copy link
Contributor

Thanks folks - Trac ticket is created:
https://core.trac.wordpress.org/ticket/60808#ticket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
5 participants
@getdave @jordesign @MaggieCabrera @annezazu @tomxygen