Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Include a "Select All" option when activating/deactivating fonts #59704

Closed
Tracked by #60528
beafialho opened this issue Mar 8, 2024 · 7 comments · Fixed by #63531
Closed
Tracked by #60528

Font Library: Include a "Select All" option when activating/deactivating fonts #59704

beafialho opened this issue Mar 8, 2024 · 7 comments · Fixed by #63531
Assignees
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@beafialho
Copy link

beafialho commented Mar 8, 2024

What problem does this address?

It's quite time consuming and burdensome to have to select each font weight when I want to add or remove an entire font family. I suggest we add a "Select All" tick at the top, like this example:

Currently:
fonts

@beafialho beafialho added the [Type] Enhancement A suggestion for improvement. label Mar 8, 2024
@jasmussen
Copy link
Contributor

Good followup to #45271 which actually already includes a table heading and a similar toggle that selects all. Here it is in an updated version with the toggle on the left:

Overview
@jasmussen
Copy link
Contributor

CC: @mikachan @matiasbenedetto for aweareness.

@annezazu
Copy link
Contributor

Noting that this is mentioned here too: #56688

@creativecoder creativecoder changed the title Font Library: Include a "Select All" option Apr 6, 2024
@creativecoder
Copy link
Contributor

Note that there's a sister issue for this related to installing fonts: #58011

@jasmussen
Copy link
Contributor

For any performance issues related to selecting multiple variants, do we already have an issue for smartly loading only the font-weights used on a particular page, or do we still need to create such an issue?

@creativecoder
Copy link
Contributor

For any performance issues related to selecting multiple variants...

@jasmussen Good question! A @font-face definition in CSS is created for each installed font variant on every page. However, modern browsers will only load the font file specified in @font-face if it's actually used in css rules for content on the page.

So selecting all the variants of a font doesn't cause a performance problem by itself--it's one extra line of html added to the page for each variant. The performance issue comes if all the variants are available, and the styles settings on a page call for loading all of them (e.g. you've picked lots of similar but different weights in the styles settings for blocks that load on the page).

@jasmussen
Copy link
Contributor

I responded here, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
6 participants