Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides in Sync Patterns: expand block support #59607

Open
liviopv opened this issue Mar 5, 2024 · 12 comments
Open

Overrides in Sync Patterns: expand block support #59607

liviopv opened this issue Mar 5, 2024 · 12 comments
Labels
[Feature] Block bindings [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.

Comments

@liviopv
Copy link

liviopv commented Mar 5, 2024

What problem does this address?

Users should be able to overrides more blocks that are can hold actual content, not just Paragraph/Heading/Image/Button

What is your proposed solution?

Some ideas:

  • List Block > List Items
  • Quote Block: citation
  • Gallery > Image
  • Verse
  • Preformatted
  • File
  • Video
  • Embed (and variations)
  • Nested blocks inside: Group, Cover, Column, Media & Text
@liviopv liviopv added the [Type] Enhancement A suggestion for improvement. label Mar 5, 2024
@gziolo
Copy link
Member

gziolo commented Mar 8, 2024

@SantosGuillamot, that’s also related to Block Bindings.

@SantosGuillamot
Copy link
Contributor

The idea is to add support for more blocks progressively to ensure everything works as expected. It's great to know which ones feel more important to have that in mind.

@jordesign jordesign added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Mar 11, 2024
@fabiankaegy
Copy link
Member

Should we also add "custom blocks" to the list here? As a developer I would love to be able to expose the block connections / pattern overrides feature in custom blocks I need to build.

@SantosGuillamot
Copy link
Contributor

Yes, custom blocks are also part of the roadmap, although it will probably take more time. They depend on the HTML API supporting any HTML tag and they will need a proper opt-in mechanism. I've added it to the block bindings API epic.

@gziolo
Copy link
Member

gziolo commented Mar 14, 2024

From the list above the Verse and Preformatted blocks should be close in implementation to the Paragraph and Heading block so if someone would like to give it a try, @SantosGuillamot and I can help with reviews.

@dannyreaktiv
Copy link

The Group block would be a great way to provide an open area for inner-blocks.

@annezazu
Copy link
Contributor

The Group block would be a great way to provide an open area for inner-blocks.

@dannyreaktiv you'll dig this issue on that exact topic: #61225

@dannyreaktiv
Copy link

The Group block would be a great way to provide an open area for inner-blocks.

@dannyreaktiv you'll dig this issue on that exact topic: #61225

Wow. Thank you!

@asafm7
Copy link

asafm7 commented Jul 18, 2024

I believe the Block Binding support for the Embed block can be useful.

Is this the best place to suggest it, or is there a dedicated thread?

@SantosGuillamot
Copy link
Contributor

I believe we can use this same conversation to gather feedback on the most important blocks 🙂

@bacoords
Copy link
Contributor

bacoords commented Jul 19, 2024

Overrides for the Cover Block Image: #63763

@jhmonroe
Copy link

jhmonroe commented Jul 26, 2024

Because of this limitation and the way the Details block is built, there's also no way for someone to use this feature in a reusable block.

A major use case is the attached image where I'm building a page of dozens of speaker bios on a page that are collapsed by default so the page isn't overwhelming.

Aside: Maybe this ship has sailed, but if the

block was treated more like a Group block wouldn't this enable someone to edit the first text as a heading or paragraph instead? (and thus the "group" could be the reusable block and all the content would be editable separately. I see now it currently outputs that first bit of text as although it styles it the same as normal paragraph text.

Attached screenshot is from v6.6.1

On Pattern Editor:
Screen Shot 2024-07-25 at 11 07 54 PM

On Page:
Screen Shot 2024-07-25 at 11 16 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block bindings [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Enhancement A suggestion for improvement.
10 participants