Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery block: Failed uploads don't render outer border line when selected #59392

Closed
fluiddot opened this issue Feb 27, 2024 · 0 comments · Fixed by #59423
Closed

Gallery block: Failed uploads don't render outer border line when selected #59392

fluiddot opened this issue Feb 27, 2024 · 0 comments · Fixed by #59423
Assignees
@dcalhoun
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

fluiddot commented Feb 27, 2024 •
edited
Loading

Description

When uploads fail in the Gallery block, the outer border line is not displayed when selecting a gallery item.

This issue is related to: Gallery block – Insert image from device (failing) – TC006

Step-by-step reproduction instructions

  1. Add a gallery block and tap "Add Media".
  2. Select "Choose from device" option.
  3. Select multiple images from the device and confirm the selection.
  4. While images are uploading, turn on airplane mode or turn off WIFI.
  5. Observe that all gallery items display an error state.
  6. Select any of the gallery items.
  7. Observe that the outer border line is not displayed when the item is selected.

Expected behaviour

Gallery items should display an outer border when they are selected.

Actual behaviour

Gallery items don't display an outer border when they are selected.

Screenshots or screen recording (optional)

ios-select-failed-upload-gallery-item.MP4

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 11
  • Operating system: iOS 17.0.2
  • WordPress app version: 24.2
@fluiddot fluiddot added [Type] Bug An existing feature does not function as intended Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Gallery Affects the Gallery Block - used to display groups of images labels Feb 27, 2024
@dcalhoun dcalhoun mentioned this issue Feb 28, 2024
Merged
@dcalhoun dcalhoun self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
2 participants
@dcalhoun @fluiddot