Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-Font Format File Upload Leads to Infinite Loading State #58874

Closed
okmttdhr opened this issue Feb 9, 2024 · 0 comments · Fixed by #58914
Closed

Non-Font Format File Upload Leads to Infinite Loading State #58874

okmttdhr opened this issue Feb 9, 2024 · 0 comments · Fixed by #58914
Assignees
@t-hamano
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@okmttdhr
Copy link
Contributor

okmttdhr commented Feb 9, 2024

Description

When attempting to upload custom fonts, the upload functionality works as expected for font files. However, when a ZIP file (or potentially other non-font file formats) is uploaded by mistake, the UI shows an infinite loading state, instead of an error message.

Step-by-step reproduction instructions

  • Go to the Font Library modal and select the Upload tab
  • Upload a zip by a drag & drop
  • See the infinite loading state

Screenshots, screen recording, code snippet

Screen.Recording.2024-02-09.at.16.19.25.mov

Environment info

Gutenberg >= 17.6

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No
@okmttdhr okmttdhr added [Type] Bug An existing feature does not function as intended [Feature] Font Library labels Feb 9, 2024
@t-hamano t-hamano mentioned this issue Feb 11, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
2 participants
@okmttdhr @t-hamano