Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Google Fonts Activation Status #58762

Closed
okmttdhr opened this issue Feb 7, 2024 · 5 comments
Closed

Inconsistency in Google Fonts Activation Status #58762

okmttdhr opened this issue Feb 7, 2024 · 5 comments
Labels
[Feature] Font Library [Type] Bug An existing feature does not function as intended

Comments

@okmttdhr
Copy link
Contributor

okmttdhr commented Feb 7, 2024

Description

After successfully activating and installing the Google Fonts asset, there is an inconsistency in the font's selection status. Despite receiving a success message indicating that the font was installed correctly, the user interface displayed the font as unchecked or unselected, suggesting it had not been chosen.

Expected Behavior:
The font should appear as selected or checked off immediately after installation, reflecting the success message.

Actual Behavior:
The font appears unchecked or as if it hadn't been selected despite the success message. However, upon navigating back to the Library tab, the font is listed as Active.

Step-by-step reproduction instructions

  • Open the Font Library modal
  • Select the Install Fonts tab
  • Click one of Google Fonts and check some variations
  • Click the Install button
  • Observe the success message confirming the font's installation.
  • Observe that the font appears unchecked
  • Select the Library tab
  • Observe that the fonts are active

Screenshots, screen recording, code snippet

Screenshot 2024-02-07 at 14 01 58

Environment info

  • Gutenberg > 17.6

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@okmttdhr okmttdhr added [Type] Bug An existing feature does not function as intended [Feature] Font Library labels Feb 7, 2024
@arthur791004
Copy link
Contributor

The condition of “checked” seems to be different from the “Library” and ”Install Fonts“.

I guess it's the expected behavior but the user may feel confused 😅

@annezazu
Copy link
Contributor

annezazu commented Feb 7, 2024

This feels related to this issue: #58276 Perhaps we can consolidate there to think about the entire experience?

@colorful-tones
Copy link
Member

This also overlaps with #58989 and considerations around UI/UX could impact both of these.

@ironprogrammer
Copy link
Contributor

IMHO this is the same as #58989, which has a bit more recent activity and design discussion going on.

@okmttdhr, would you mind if this issue was closed and continued to be tracked over in #58989?

@arthur791004
Copy link
Contributor

Sure. Let's close this one in favor of #58989 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Type] Bug An existing feature does not function as intended
5 participants