-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fontFeatureSettings in theme.json #56619
Comments
Noting that this appears to exist (#47127) but is not working as expected. |
@jordesign @richtabor Can one of you switch the tags on this from Enhancement to Bug? And upon further review, the @font-face rules seem to be in place, but not working:
However, if I add the following CSS in style sheet, it works:
|
Sure can @bgardner :) |
@t-hamano Well snap, that’s something I didn't expect. Usually Chrome is at the forefront of these things, but after testing, I believe you are right. (Which is kind of annoying because Chrome is such a large % of browser.) |
I don't know why this feature got supported, but technically this issue is a browser support issue, not a Gutenberg issue. So while it's hard to call this a bug, we feel it might be a good idea to update the JSON Schema description to indicate that this feature is not yet supported by major browsers. |
What problem does this address?
With all of the fonts available to theme developers, it would be great to add support for fontFeatureSettings in theme.json. AFAIK, there is no way to add this setting on a per-font basis. Putting this in a style sheet is not ideal for themes that provide multiple fonts, as there could be some undesirable outcomes depending on which font is selected.
What is your proposed solution?
Include support for font-feature-settings similar to this:
The text was updated successfully, but these errors were encountered: