Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy from "template preview" to "show template" #56269

Closed
annezazu opened this issue Nov 17, 2023 · 4 comments
Closed

Update copy from "template preview" to "show template" #56269

annezazu opened this issue Nov 17, 2023 · 4 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Digging into the template preview feature during a recent hallway hangout, we discussed the language around "template preview" being confusing in that one would expect this to bring you to a template preview. I see this was decided here. Can we return to the original proposed language with "show template"?
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Type] Copy Issues or PRs that need copy editing assistance [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts labels Nov 17, 2023
@annezazu annezazu mentioned this issue Dec 7, 2023
Open
@jasmussen
Copy link
Contributor

CC: @jameskoster
@jameskoster
Copy link
Contributor

The concern with "Show template" was that it might be interpreted as a setting for the post/page, and consequently affect the frontend. That was purely an assumption though, so no harm trying it imo.
@carolinan
Copy link
Contributor

It took me some time to figure out what part of the interface you meant.

I think it might be easier if the text changed depending on the state, so that when the template is visible, the text could say "Hide template"
@carolinan carolinan mentioned this issue Jan 12, 2024
Merged
@juanfra
Copy link
Member

juanfra commented Jul 4, 2024

Closing as completed in #57802
@juanfra juanfra closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
5 participants
@juanfra @jameskoster @jasmussen @carolinan @annezazu