Spacing: Spacing Sizes are added

[hanneslsm]

Description

Spacing sizes are getting added to the list, even though I have defined different ones in my theme.
This seems to happen to any theme that does not have 1, 2, 3… defined as spacing size.

Step-by-step reproduction instructions

1. Select a theme with custom spacing sizes
2. Wonder where the new spacing sizes are coming from

Screenshots, screen recording, code snippet

Environment info

• WP 6.4-RC2
• GB 16.9.0

Please confirm that you have searched existing issues in the repo.

No

Please confirm that you have tested with all plugins deactivated except Gutenberg.

No

[hanneslsm]

i thought maybe i could get around the problem by using 1,2,3... as a slug, but that doesn't change anything either.

Edit: Just saw that TT4 used 10 as a slug for 1. The bug still exists with 10 as slug.

[bgardner]

I can confirm this is happening. My Powder theme sets Spacing presets (xSmall, Small, Medium, Large, xLarge) with the following, but numbers are being added per the video below. The slider no longer exists, rather a drop down menu.

"spacing": {
	"spacingSizes": [
		{
			"name": "xSmall",
			"size": "20px",
			"slug": "x-small"
		},
		{
			"name": "Small",
			"size": "clamp(30px, 4vw, 40px)",
			"slug": "small"
		},
		{
			"name": "Medium",
			"size": "clamp(40px, 6vw, 60px)",
			"slug": "medium"
		},
		{
			"name": "Large",
			"size": "clamp(50px, 8vw, 80px)",
			"slug": "large"
		},
		{
			"name": "xLarge",
			"size": "clamp(60px, 10vw, 100px)",
			"slug": "x-large"
		}
	],
	"units": [ "%", "px", "em", "rem", "vh", "vw" ]
}

Screen.Recording.2023-10-26.at.1.16.00.PM.mov

[carolinan]

From the screenshot of theme.json, It does not look like you have disabled the default sizes by adding

			"spacingScale": {
				"steps": 0
			},

Do I understand correctly that you are experiencing that this is a change from previous WP or Gutenberg versions?

[hanneslsm]

Thanks @carolinan - this has solved the issue!

Do I understand correctly that you are experiencing that this is a change from previous WP or Gutenberg versions?

Yes, defining the spacingScale was not necessary in previous versions. I leave this issue open to clarify if this is intended or a bug.

[carolinan]

I would expect the disabling to use the same format as colors:

			"defaultDuotone": false,
			"defaultPalette": false,
			"defaultGradients": false,

[bgardner]

@carolinan Thanks for calling that out. I’ll have to go back to my commits in Powder because I swear I had that code in my theme.json file. Nonetheless, I have added it to the theme and no longer am experiencing the issue.

[dabowman]

Just bumping this. I noticed the same thing. a boolean to toggle off the default spacing scale would be excellent. maybe settings.spacing.defaultScale to follow the pattern from the color object.

[carolinan]

I am no longer able to reproduce this.
When a theme adds its own spacing sizes, with or without editing the spacing scale, then the default sizes are not added.
Also see #60129