Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: add option to revoke access to Google Fonts #54826

Closed
liviopv opened this issue Sep 26, 2023 · 8 comments · May be fixed by #59412
Closed

Font Library: add option to revoke access to Google Fonts #54826

liviopv opened this issue Sep 26, 2023 · 8 comments · May be fixed by #59412
Assignees
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@liviopv
Copy link

liviopv commented Sep 26, 2023

What problem does this address?

Font Library > Install shows a very cautious warning about allowing access to Google Fonts, but there's no way to revoke that access once it's granted.

What is your proposed solution?

There needs to be an action button that revokes access to Google Fonts and brings the modal back to its initial state.

CleanShot 2023-09-26 at 14 14 34@2x

@matiasbenedetto
Copy link
Contributor

Thanks for proposing this feature. I added under "Needs discussion" in stage 3 tracking issue.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Typography Font and typography-related issues and PRs labels Sep 27, 2023
@matiasbenedetto
Copy link
Contributor

Technically this would be simple to implement but we would need to add an UI element if we decide to implement it.

@jasmussen I would like to have your input about this.

@matiasbenedetto
Copy link
Contributor

Linking a closely related issue: #58774

@annezazu annezazu added the Needs Design Feedback Needs general design feedback. label Feb 7, 2024
@jasmussen
Copy link
Contributor

How's this ellipsis menu?

Revoke permission

By the way, be mindful of the details in the existing mockups, there's a lot that's diverging in trunk at the moment:

Screenshot 2024-02-08 at 08 07 44

It's possible I'm missing context from other reviews, so correct me if I'm wrong. But the connect box should be vertically centered, I'd avoid the "Google Fonts" heading (the introductory paragraph is sufficient), the width, height and padding of the box is off, the line-height of the warning is wrong, and the "Allow access" button should be centered, or full-width. I realize there's a separate issue for changing the text, that's fine. And finally, a comma is missing from the introductory paragraph.

@getdave
Copy link
Contributor

getdave commented Feb 13, 2024

If we implement this how hard would it be to make it provider agnostic. So say Theme A bundles a specific provider of fonts, could we make the UI able to revoke access to that collection also?

The primary objective should be to allow Google Fonts to be revoked in 6.5 though 👍

@matiasbenedetto
Copy link
Contributor

Linking this issue here as closely related: #58774

@youknowriad
Copy link
Contributor

So this has been implemented already, Any reason we're keeping the issue open?

@matiasbenedetto
Copy link
Contributor

Closing this issue as fixed by: #59205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
9 participants