Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can leave Block Theme Previews without noticing #53935

Open
okmttdhr opened this issue Aug 25, 2023 · 1 comment
Open

Users can leave Block Theme Previews without noticing #53935

okmttdhr opened this issue Aug 25, 2023 · 1 comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@okmttdhr
Copy link
Contributor

okmttdhr commented Aug 25, 2023

Description

In the following cases, users can "leave" the Block Theme Previews, which means users cannot activate a previewing theme. See the reproduction instructions below.
This should be addressed to allow the URL query ?wp_theme_previews= to be retained.

Step-by-step reproduction instructions

  1. Go to /wp-admin/themes.php and click the Live Preview button for a Block theme
  2. Click the preview to open the edit canvas -> Click the command center and navigate to another part of the Site Editor, e.g., a header or footer template part.
  3. Observe the URL query ?wp_theme_previews= has gone and the subsequent page transitions occur without the URL query, which means users have no way to activate a theme.
Screen.Recording.2023-08-25.at.14.37.44.mov

Replacing step 2 above with one of the following will also reproduce the bug;

  • On the Patterns menu, click Create pattern
  • On the Patterns menu, click Create template part
Screen Shot 2023-08-25 at 14 31 15
  • On the Patterns menu, click Copy to My patterns
    Image from Gyazo

  • On the Templates menu, click + sign and add a new template
    Image from Gyazo

  • On the Pages menu, click + sign and add a new page
    Image from Gyazo

Screenshots, screen recording, code snippet

No response

Environment info

  • Gutenberg 16.5.0
  • WordPress 6.3

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Aug 28, 2023
@annezazu
Copy link
Contributor

@scruffian wanted to flag this for you as there are some improvements to look into, perhaps for 6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
3 participants