Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo: Add aspect-ratio tool for custom image dimensions #52169

Closed
iamtakashi opened this issue Jun 30, 2023 · 4 comments
Closed

Site Logo: Add aspect-ratio tool for custom image dimensions #52169

iamtakashi opened this issue Jun 30, 2023 · 4 comments
Assignees
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.

Comments

@iamtakashi
Copy link

The aspect ratio control for custom image dimension has been very helpful.

Can we have that for the Site Logo block too? It could be useful for some themes that are designed with a specific logo size and an aspect ratio in mind.

@priethor priethor added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Jun 30, 2023
@draganescu draganescu self-assigned this Sep 11, 2023
@richtabor
Copy link
Member

I struggle with identifying when a site logo should have an aspect ratio assigned to it. The only instance I can think of is for when your avatar is your site logo. Otherwise, I don't think users would expect to replace a logo with their own and have it conform to a different aspect ratio.

Images work better, because there can be some soft-cropping, but logos can't.

@draganescu
Copy link
Contributor

Yes, despite jumping quickly and trying to add the feature (see try/site-logo-ar), I second @richtabor 's problem above. Usual users will have a logo that is what it is - a photo, a drawing, some clipart. The profesional designer will have multiple variants of the logo. So setting a constraint in a pattern for the site logo in terms of aspect ratio does not look useful.

Maybe in terms of suggestion? Like, this aspect ration would look best.

@iamtakashi
Copy link
Author

Thank you both for the feedback. Yes, @richtabor, I had the Hey theme in mind when I made this request. It's probably too niche.

@scruffian
Copy link
Contributor

I think we should close this one as it doesn't seem like a good idea for the reasons above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block [Type] Enhancement A suggestion for improvement.
5 participants