Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnotes Block: unable to insert footnote on Paragraph inside Quote Block #52084

Closed
liviopv opened this issue Jun 28, 2023 · 2 comments · Fixed by #52241
Closed

Footnotes Block: unable to insert footnote on Paragraph inside Quote Block #52084

liviopv opened this issue Jun 28, 2023 · 2 comments · Fixed by #52241
Assignees
Labels
[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended

Comments

@liviopv
Copy link

liviopv commented Jun 28, 2023

Description

Unlike on other blocks with nested blocks (Cover, Media & Test), Footnotes are not working properly on the Quote Block. The link in the highlighted piece of text will be added, but the editor will not jump correctly to the Footnote Block

Step-by-step reproduction instructions

  1. Add the Quote Block to a post or page
  2. Add a Paragraph inside the quote
  3. Add a Footnote to the Paragraph
  4. The superscript link will be added to the highlighted text, but the screen will not just to the Footnote Block correctly, allowing to add the footnote

Screenshots, screen recording, code snippet

CleanShot.2023-06-28.at.18.08.54.mp4

Environment info

WordPress 6.2.2, Gutenberg 16.1 running on Local
Chrome 114, MacOS 13.0.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@liviopv liviopv changed the title Footnotes: unable to insert footnote on Paragraph inside Quote Bloclk Jun 28, 2023
@liviopv liviopv changed the title Footnotes: unable to insert footnote on Paragraph inside Quote Block Jun 28, 2023
@ndiego ndiego added [Type] Bug An existing feature does not function as intended [Block] Footnotes Affects the Footnotes Block labels Jun 29, 2023
@ndiego
Copy link
Member

ndiego commented Jun 29, 2023

I am able to confirm as well. cc @ellatrix

@ellatrix
Copy link
Member

The problem here is that these blocks use InnerBlocks.Content. So turns out footnotes is not compatible with InnerBlock.Content because it’s wrapped in a function component. It is compatible with useInnerBlocksProps.save, because that just returns the blocks without a wrapper component. 🤔 Not sure how we can make this work, other than just deprecating InnerBlock.Content...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Footnotes Affects the Footnotes Block [Type] Bug An existing feature does not function as intended
4 participants