Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to filter toolbar controls in Query block variations #50458

Open
jeremyfelt opened this issue May 9, 2023 · 1 comment
Open
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.

Comments

@jeremyfelt
Copy link
Member

What problem does this address?

When registering a variation for the Query block, it is possible to define the perPage, offset, and pages attributes so that they are prefilled with the variant is added. In some cases, this is a specific variation in which these attributes should not change. Currently, it is possible to immediately change these attributes through the "Display settings" dropdown in the toolbar.

What is your proposed solution?

It would be great if the individual attributes—perPage, offset, and pages—could be removed through the allowedControls property. It could also be useful to allow for the entire removal of the "Display settings" dropdown itself.

@jeremyfelt jeremyfelt added the [Block] Query Loop Affects the Query Loop Block label May 9, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 20, 2023
@carstingaxion
Copy link
Contributor

I wish to do the same with my fork of @ryanwelcher|s Advanced query block plugin, where some of the (native & extended) controls do not fit my use-case of a contextual query block.

Without looking into the code, but shouldn’t it be possible to have all the controls placed within a slot and then unregister specific fills, when not needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Type] Enhancement A suggestion for improvement.
3 participants