Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read shortcode block text on themes with white text #49482

Closed
tomjn opened this issue Mar 30, 2023 · 2 comments · Fixed by #49723
Closed

Cannot read shortcode block text on themes with white text #49482

tomjn opened this issue Mar 30, 2023 · 2 comments · Fixed by #49723
Assignees
Labels
[Block] Shortcode Affects the Shortcode Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Bug An existing feature does not function as intended

Comments

@tomjn
Copy link
Contributor

tomjn commented Mar 30, 2023

Description

The shortcode block has a textbox with a white background.

On themes with white body text, the textbox has white text on a white background, which is unreadable:

Step-by-step reproduction instructions

  1. Activate a theme with a dark colour palette and white text
  2. Try to type in a shortcode blocks input

Screenshots, screen recording, code snippet

Screenshot 2023-03-30 at 15 24 29

Environment info

  • WP 6.2
  • Chrome
  • MacOS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added CSS Styling Related to editor and front end styles, CSS-specific issues. [Block] Shortcode Affects the Shortcode Block labels Apr 1, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Apr 1, 2023

Thanks for the report.

I could not reproduce it with Twenty Twenty Three. The Shortcode block overrides the theme text color with black:

placeholder


And since the textarea inherits its color, the text should also appear in black:

plain-text


From your screenshot, it appears that the style of this block is different from the default. Have you defined any CSS on the theme side that would override the text color of this block?

@tomjn
Copy link
Contributor Author

tomjn commented Apr 1, 2023

Yes, there are styles that set basic inputs, but these should not be influencing block editor chrome, much in the same way that headings in placeholder components don't look like headings in the block list. i've raised a number of issues over the years and have been told to raise a bug if this happens in the past

@Mamaduka Mamaduka self-assigned this Apr 11, 2023
@Mamaduka Mamaduka added the [Type] Bug An existing feature does not function as intended label Apr 11, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 11, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Shortcode Affects the Shortcode Block CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Bug An existing feature does not function as intended
4 participants