Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Browse styles animation is too slow #49120

Closed
miminari opened this issue Mar 15, 2023 · 3 comments
Closed

Site Editor: Browse styles animation is too slow #49120

miminari opened this issue Mar 15, 2023 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Performance Related to performance efforts

Comments

@miminari
Copy link
Member

Description

When a user selects a variation of the Browse styles in the Site Editor, the transition when the site preview display switches seems to be too slow and takes too long to fully display the site.

Perhaps the transition( transition: all 0.3s ease 0s; ) set in the iframe needs to be adjusted.

Step-by-step reproduction instructions

  1. Activate Block Themes
  2. Go to 'Site Editor'
  3. Click Site View
  4. Click 'Styles'
  5. Click 'Browse styles'
  6. Choose a variation

Screenshots, screen recording, code snippet

Kapture.2023-03-16.at.08.33.22.mp4

Environment info

  • WordPress 6.1.1
  • Gutenberg 15.3.1
  • Mac OS 12.5.1
  • Google Chrome 111.0.5563.64

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@miminari miminari added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Mar 15, 2023
@inc2734
Copy link
Contributor

inc2734 commented Mar 16, 2023

Same issue ?

Kapture.2023-03-16.at.14.58.10.mp4

The list of patterns displayed when creating a new page also grows slowly, depending on the content.

@kathrynwp kathrynwp added the [Type] Performance Related to performance efforts label Mar 16, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Mar 23, 2023

Upon investigation, this problem occurs when the block uses units such as vh that is dependent on the height of the viewport. In the Twenty Twenty Three reported here, vh is used for the height of the post featured image.

For example, this can be reproduced by using vh as the unit for the min-height of the group block. Perhaps the height calculation of the iframe editor instance and the height of the blocks that depend on it interact to cause this unintended behavior.

81b7e18b1a588e6fa0717e4242b87150.mp4

However, this problem is not reproduced in WordPress 6.2 with the Gutenberg plugin disabled. Perhaps one of the reasons may be that the latest Gutenberg applies a calculated height to the iframe editor instance.

iframe

@t-hamano
Copy link
Contributor

I believe this issue has been fixed in #59334, but if you can reproduce this issue on trunk, feel free to reopen it at any time.

ced01be7de1041f0b257dd26e5dd010e.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Performance Related to performance efforts
4 participants