Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for presets in minimum height fields #48810

Open
cbirdsong opened this issue Mar 6, 2023 · 0 comments
Open

Add support for presets in minimum height fields #48810

cbirdsong opened this issue Mar 6, 2023 · 0 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@cbirdsong
Copy link

cbirdsong commented Mar 6, 2023

The cover block has long supported entering custom minimum height values, and support was just added to the group and post content blocks: https://make.wordpress.org/core/2023/03/06/minimum-height-dimensions-block-support/

However, entering in a simple custom value rarely works well for responsive web design. vh units can work decently, but the field defaults to px and the particulars of the different CSS unit options are not easy for content editors to understand. On top of that, you really need to be able to use min, max and clamp values for a great responsive design.

To address that, the editor should support registering custom presets for the height field. The default editing experience should have the user pick from a list of presets with an option to enter a custom value, and themes should be able to disable entry of custom values. This would make the height field work exactly like spacing fields.

This could also replace the "Toggle full height" button that switches the cover block to full height since "full" could be one of the presets.

@andrewserong andrewserong added Needs Design Feedback Needs general design feedback. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Type] Enhancement A suggestion for improvement. labels Mar 6, 2023
@cbirdsong cbirdsong changed the title Add support for presets in "minimum height" fields Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
2 participants