Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Logo block options do not appear if SVG is selected (Firefox) #43130

Open
coreyworrell opened this issue Aug 10, 2022 · 5 comments
Open
Labels
[Block] Site Logo Affects the Site Logo Block Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended

Comments

@coreyworrell
Copy link
Contributor

Description

In Firefox, if you select an SVG image for the Site Logo block, the Settings panel disappears. You cannot set the image width, link to home, etc.

Step-by-step reproduction instructions

  1. Insert Site Logo block
  2. Upload/select an .svg file

Screenshots, screen recording, code snippet

JPG selected:

image

SVG selected:

image

Environment info

  • WP 6.0.1
  • Firefox 103.0
  • Ubuntu 20.04.4

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems [Block] Site Logo Affects the Site Logo Block labels Aug 10, 2022
@carolinan
Copy link
Contributor

SVG is not a supported file format for the logo. Until WordPress core officially supports uploading svg's securely, I think this needs to be labeled as a feature request, not a bug?

Related: https://core.trac.wordpress.org/ticket/24251

@luminuu
Copy link
Member

luminuu commented Nov 8, 2023

Can confirm this is still a problem with Firefox. Does work with Chrome and Safari. I'd consider it as a bug, even if SVGs are not officially supported, but it does work in other browsers.

@coreyworrell
Copy link
Contributor Author

@luminuu I've found that if the SVG does have both width and height attributes, then it works correctly in the editor. We also use the Safe SVG plugin.

@t-hamano
Copy link
Contributor

I was also able to reproduce this problem. Furthermore, in Chrome, if you set an SVG image without width/height attributes as the site logo and then try to resize it, the icon disappears. The resizing issue does not occur with the Media & Text or the Image blocks.

This problem may be considered to be a problem specific to the Site Logo block.

e5030c3767e0b8cfeed27bf5c6cc2e8a.mp4
@diniciacci
Copy link

I can confirm this bug as still present with WP 6.6.1. In particular I'm referring to the part also mentioned in #46784 about resizing of SVG not working. That part does not work in any browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Logo Affects the Site Logo Block Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
6 participants