Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block style removal should be considered a breaking change #42275

Open
cbirdsong opened this issue Jul 8, 2022 · 4 comments
Open

Block style removal should be considered a breaking change #42275

cbirdsong opened this issue Jul 8, 2022 · 4 comments
Labels
[Block] Quote Affects the Quote Block [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Type] Regression Related to a regression in the latest release

Comments

@cbirdsong
Copy link

In 6.0, the "large" style was removed from the quote block. Going off #37580, I see the rationale was that this was obviated by the font size picker in typography options. However, "large" did not necessarily mean only the font size. On an older custom theme, I had styled the standard style with a subtle quote frame treatment, and the large style increased visual prominence in every way, not just font size:

Unstyled:
Quote block, unstyled

Large style:
Quote block, large style

Updating to 6.0 removed this style from the sidebar in the editor, making it unavailable to editors of the site until I re-registered it. If they did not have a theme developer available it would've been gone forever, and this being a problem doesn't seem to have occurred to anyone during discussion of this change.


Separately, I also now face the specificity problems mentioned in #41219 and #40163 even though I've opted out of using core styles on the front end.

Editor screenshots before/after installing 6.0

Large style before 6.0:
Quote block, large style, with text clearly visible

Large style after 6.0:
Quote block, large style, with text covered by ornamental accent mark

@kathrynwp kathrynwp added the [Block] Quote Affects the Quote Block label Jul 11, 2022
@kathrynwp
Copy link

Pinging @carolinan, @ramonjd and @ntsekouras, for your thoughts.

@mtias mtias added the [Type] Regression Related to a regression in the latest release label Jul 27, 2022
@carolinan
Copy link
Contributor

I understand that this was problematic. In hindsight this could have been avoided if the theme had registered its own custom block style instead of adding CSS to an existing core block style.
Also consider that both plugins and themes can unregister the core styles.

@fabiankaegy fabiankaegy added the [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks label Oct 24, 2023
@carolinan
Copy link
Contributor

carolinan commented Oct 25, 2023

Are there any actionable items here? Or did you only mean this as a reminder?

I mean are you suggesting some sort of revert or re-adding the style?

@cbirdsong
Copy link
Author

More a reminder that changes to the default block styles should not be done lightly? I don't think a revert is the move since it's been gone for more than a year, but no one seemed to think about existing themes assuming the "large" style would continue to exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Block Style Variations Issues or PRs that are related to the style variations for blocks [Type] Regression Related to a regression in the latest release
5 participants