Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in test description for didPostSaveRequestSucceed #39356

Closed
salcode opened this issue Mar 10, 2022 · 2 comments · Fixed by #41064
Closed

Typo in test description for didPostSaveRequestSucceed #39356

salcode opened this issue Mar 10, 2022 · 2 comments · Fixed by #41064
Assignees
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended

Comments

@salcode
Copy link

salcode commented Mar 10, 2022

Description

The didPostSaveRequestSucceed test description says

should return true if the post save request has failed

but it should say

should return false if the post save request has failed

it( 'should return true if the post save request has failed', () => {
const state = {
saving: {
successful: false,
},
};
expect( didPostSaveRequestSucceed( state ) ).toBe( false );
} );

Step-by-step reproduction instructions

n/a

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@karmatosed karmatosed added the Needs Testing Needs further testing to be confirmed. label Mar 30, 2022
@KAJALwp
Copy link

KAJALwp commented Apr 5, 2022

Hello @salcode, @karmatosed

I have also crossed verified the text and yes it shows true instead of false.

Thank you.

@t-hamano
Copy link
Contributor

@salcode

I also checked and found one more description where there is a discrepancy.
It should say false, not true.

it( 'should return true if the post save request is successful', () => {
const state = {
saving: {
error: false,
},
};
expect( didPostSaveRequestFail( state ) ).toBe( false );
} );

Is it possible to submit a PR for these two descriptions if you would like?

@skorasaurus skorasaurus added [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts and removed Needs Testing Needs further testing to be confirmed. labels Apr 26, 2022
@amustaque97 amustaque97 self-assigned this May 13, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 13, 2022
@t-hamano t-hamano removed Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress labels Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
6 participants