Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Multiline Components: Loss of Previous Lines when Starting Multiple New Lines #29861

Closed
SiobhyB opened this issue Mar 15, 2021 · 3 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects

Comments

@SiobhyB
Copy link
Contributor

SiobhyB commented Mar 15, 2021

Description

When entering multiple new lines in a block that has a multiline component, the cursor sometimes behaves in an unexpected way (either moving to the top of the block or moving to a brand new block) and this can lead to lines being wiped/lost.

I have been able to replicate this on Android devices only and with the following four blocks: Quote, Verse, Preformatted, Pullquote

This is similar to the issue described in #27690, but I'm creating a separate issue as it's slightly different in that I've been able to replicate this while the cursor is at the end of the block and there is a loss of lines/content in this scenario.

Similar to this issue, there are times where the steps work as expected and it can be tough to reliably reproduce this. You'll see in this thread that I had mistakenly thought this was specific to a new branch as I'd had difficulty replicating on the main branch. I've since been able to replicate this on the latest alpha version of the Android app.

Step-by-step reproduction instructions

The most reliable way I have found to replicate this issue is as follows:

  1. In the post editor on an Android device, add a new Quote or Pullquote block.
  2. Enter a line of text and then tap the enter key twice in succession.
  3. Notice how the second empty line is removed.

Expected behaviour

In the steps provided, I would expect the block to contain three lines, with the second line being empty and my cursor being in the third line.

Actual behaviour

The second (empty) line is removed in the above steps. The user in this scenario should be typing into the third line, but this ends up being the second line:

Removed.pullquote.line.mov

Although trickier to reliably reproduce, I have been able to replicate what you see in the following video on the latest version of app, where actual text (rather than just an empty line) is removed when entering multiple lines in a multiline component:

preformatted.mov

WordPress information

Tested using a simple (no plugins) WordPress.com site.

  • WordPress version: 5.7
  • Gutenberg version: 10.1.1
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: Pixel 5
  • Operating system: Android 11
  • WordPress app version: 16.8.1
@SiobhyB SiobhyB added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 15, 2021
@SiobhyB SiobhyB changed the title Mobile: Multiline Components: Loss of Previous Lines when Starting Multiple New lines Mar 15, 2021
@mchowning mchowning added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Mar 15, 2021
@mchowning mchowning added this to Triage in Mobile Apps via automation Mar 15, 2021
@mchowning mchowning moved this from Triage to To do in Mobile Apps Mar 15, 2021
@mchowning
Copy link
Contributor

I initially overlooked that it was possible to lose content beyond an empty line here, so updating the priority to be High.

@mchowning mchowning added [Priority] High Used to indicate top priority items that need quick attention and removed [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Mar 16, 2021
@AmandaRiu
Copy link
Contributor

AmandaRiu commented Jul 12, 2021

FYI: This is still an issue as of 1.57.0. I was in here already completing writing flows tests so I thought I'd make a note of it.

verse-block.mp4

Tested on physical Pixel 4 running Android 11 w/ Gboard

@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Aug 17, 2023
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Dec 20, 2023

I tested this in the most recent production build (23.8.1) and have not been able to reproduce. As there have been no other reports since July, 2021, I assume this has been resolved. Going ahead to close this issue 🎉

@SiobhyB SiobhyB closed this as completed Dec 20, 2023
Mobile Apps automation moved this from To do to Done Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
4 participants