Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-width blocks touching browser edges #20646

Closed
alaczek opened this issue Mar 5, 2020 · 10 comments
Closed

Full-width blocks touching browser edges #20646

alaczek opened this issue Mar 5, 2020 · 10 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback.

Comments

@alaczek
Copy link

alaczek commented Mar 5, 2020

Is your feature request related to a problem? Please describe.
A couple content-based blocks (Archives, Categories, Latest Posts, Latest Comments ) offer full-width option, but have no basic styles built in to ensure the content does not touch browser edges. This puts the responsibility of implementing basic margin/padding styles on the theme authors.

Here's how this looks like in TwentyTwenty:
full_width_blocks

Describe the solution you'd like
It would be great if some basic horizontal spacing was built into these blocks, to ensure they look ok out of the box.

@nielslange
Copy link
Contributor

Seems to be related to #20589 (review) and according to #20589 (comment) this issue seems to be fixed.

@alaczek
Copy link
Author

alaczek commented Mar 6, 2020

Hmm... I don't see any of the block mentioned above make use of columns under the hood. Also, this issue happens on desktop, as well as mobile.

@nielslange
Copy link
Contributor

My bad, I thought these issues were related to each other. 🤭

@MDWolinski
Copy link

Was discussed in Design meeting today. One thought is that a full width block is expected to touch the browser edges and if the theme wants change that behavior, it should be the theme that defines that.

@paaljoachim
Copy link
Contributor

Any additional comments to this issue?
Should we close it or do something else with it...?

@mapk mapk added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Nov 24, 2020
@mapk
Copy link
Contributor

mapk commented Nov 24, 2020

@ItsJonQ is there a global style control being worked on for adjusting padding/margins on blocks?

@paaljoachim
Copy link
Contributor

paaljoachim commented Nov 24, 2020

Brainstorming coming up...
Ahh this could be a kind of content width and margin for blocks.
Or like a content is 90% of the width of the screen.
If one wants a blocky kind of feel one might do less. Have a border + border radius around the content. Perhaps even a drop shadow.

EDIT: I added this comment: #26633 (comment)
Showing a visual to give a better idea of what I am talking about.

@carolinan
Copy link
Contributor

I expect full width blocks that has text content or form elements to have some default horizontal spacing, otherwise they become difficult to read.

But these should be editable with settings/global styles.

@ItsJonQ
Copy link

ItsJonQ commented Dec 7, 2020

is there a global style control being worked on for adjusting padding/margins on blocks?

@mapk There's a Padding spacing tool available, but I believe it's only activated for certain blocks at the moment.

@mtias
Copy link
Member

mtias commented Aug 2, 2023

I think this is no longer relevant with the global styles layout tools.

@mtias mtias closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Design Feedback Needs general design feedback.
9 participants