File Block: file name needs to use PlainText component

[ocean90]

Describe the bug
formattingControls of RichText should be honored in pasting within the block.`

To Reproduce

1. Add a file block
2. Copy this text: File name
3. Paste text into file name
4. Note that there's no way to remove the link
5. Save post and reload page
6. Block is now invalid "This block contains unexpected or invalid content."

Expected behavior
No formatting should be applied if formattingControls is empty.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context

• Related Slack discussion: https://wordpress.slack.com/archives/C02QB2JS7/p1540301310000100

[ocean90]

Noting that all the keyboard shortcuts for text formatting are also working here. Maybe this shouldn't be a RichText field in the first place? Or what about introducing a plain prop which disallows any formatting?

/cc: @iseulde

[ellatrix]

Why can't we just use the PlainText component for this? :)

[nitishkaila]

@ocean90, I have created a PR for solution of above issue. Kindly review it.

[ellatrix]

Worth noting that PlainText is an enhanced textarea element. I don't know what's more suitable here. You could also use an input control.

[ellatrix]

(From what I understand, RichText was only used here for how it looks, not for its functionality. :/)

[prajapatisagar]

@ocean90 and @iseulde Is there any update about this ticket? I have also tested this patch and it is working fine.

[talldan]

In the latest version of Gutenberg it looks like you can remove the link, but that's because the file block now has link formatting. That seems like a new issue that needs to be solved.

The same problem is also present with the download button.

[paaljoachim]

WordPress 5.7 beta 3 and Gutenberg plugin 10.
Twenty Twenty One.

Added a file block. Removed the text link.
This is what I see in the backend.

Is the issue still valid based on what was reported?
@ocean90

[glendaviesnz]

I just retested with WP5.8 and Gutenberg 11.3 and there is still no way to edit/remove a link if linked text is pasted into the filename field.

[aurooba]

^ Working on it!

[paaljoachim]

Thank you @aurooba
I went ahead and assigned the issue to you.

[paaljoachim]

Should the file name, button, and the file become inner blocks?
I assume so as each would have their own properties/options. As the user would then also be able to move each around, and align each as they would like.

I will also bring in this somewhat associated issue (which also could use a closer look):
PDF thumbnail preview
#15097

[aurooba]

@paaljoachim I'm going to try two things today: innerBlocks is a good idea, you're right, why can't we make the block more flexible? Also I'm not sure the PlainText component is correct, I think RichText is still the right way to go with the link functionality exposed so it can be changed/edited. I have to test a bit more, because obviously we don't want the initial issue @ocean90 reported to be a thing.

#15097 definitely feels related. I'm going to tackle this issue first, and then I can start some explorations around the PDF issue as well. :)

[paaljoachim]

That is great! Thank you @aurooba

[carolinan]

I am no longer able to reproduce the issue.
In WordPress 6.2, it is possible to remove both the text and the link, and there are no validation errors when the content is saved and the page reloaded.

[paaljoachim]

It is now possible to click into the file name and adjust it directly in the Gutenberg canvas/document area.

We should now be able to close this issue.

@aurooba it would be very helpful if you have a chance to look at the
PDF thumbnail preview issue
#15097
Thanks!

[akasunil]

Closing this as can't reproduce with gutenberg 18.5.0