Disallow mkdir in favor of wp_mkdir_p

[kkmuffme]

Is your feature request related to a problem?

Disallow mkdir in favor of wp_mkdir_p

To allow for extendability of the mkdir via wp_mkdir_p, to ensure the directories are automatically created with correct permissions (& also ensures that devs dont even try to "0777" work around)

[jrfnl]

Ref: https://developer.wordpress.org/reference/functions/wp_mkdir_p/

[rodrigoprimo]

@jrfnl, I was looking for good first issues to contribute to this repository and I found this one. Is the idea of this issue to add mkdir to the list of functions in WordPress.PHP.RestrictedPHPFunctions?

I noticed that mkdir is already flagged by WordPress.WP.AlternativeFunctions. Mentioning this in case it was not considered already.

Thanks

[jrfnl]

@rodrigoprimo Maybe you should ask the OP instead of me ?

It may also be that this was fixed already without anyone noticing that this issue could be closed.

[kkmuffme]

@rodrigoprimo if it's already in WordPress.WP.AlternativeFunctions this might have been fixed in the meantime.

Can you confirm that you get an error for code like:

mkdir( ABSPATH . '/testing' );

If yes, this issue can be closed

[dingo-d]

You will get a warning

File operations should use WP_Filesystem methods instead of direct PHP filesystem calls. Found: mkdir(). (WordPress.WP.AlternativeFunctions.file_system_operations_mkdir)

So I'll close this.