Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - Enhance Syntax Highlighting on the course content #2487

Open
laxmariappan opened this issue Jun 1, 2024 · 4 comments
Open

Feedback - Enhance Syntax Highlighting on the course content #2487

laxmariappan opened this issue Jun 1, 2024 · 4 comments
Assignees
Labels
[Component] Content Website development issues related to the content on Learn. [Content] Feedback Feedback provided about content on Learn.

Comments

@laxmariappan
Copy link

Type of feedback

//content

Description

Can we enhance the syntax highlighting on the training content?

Step-by-step reproduction instructions (optional)

Go to https://learn.wordpress.org/lesson/accessing-wordpress-data/
You can view a couple of code blocks
They have both JS and PHP code.
But as a reader I find it hard to differentiate code

Screenshots or screen recording (optional)

Without highlighting on the page:

image

Demo of syntax highlighting

image

Other information (optional)

@laxmariappan laxmariappan added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Jun 1, 2024
@github-actions github-actions bot added the [Content] Feedback Feedback provided about content on Learn. label Jun 1, 2024
@jonathanbossenger
Copy link
Collaborator

@laxmariappan thanks for logging this.

This is a known issue that's related to the current classic theme that Learn.WordPress.org uses.

As we're busy developing a new block theme, once the new theme launches, this issue should be resolved.

cc @adamwoodnz it would be great if we could confirm that the code block syntax highlighting works as expected for lessons when the new theme is developed.

@adamwoodnz
Copy link
Contributor

As we're busy developing a new block theme, once the new theme launches, this issue should be resolved.

cc @adamwoodnz it would be great if we could confirm that the code block syntax highlighting works as expected for lessons when the new theme is developed.

Thanks, I'll add it to the redesign project.

@adamwoodnz adamwoodnz added this to the Learning Pathways launch milestone Jun 3, 2024
@adamwoodnz adamwoodnz added [Component] Learn Theme Website development issues related to the Learn theme. Dev labels Jun 3, 2024
@jonathanbossenger jonathanbossenger removed the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Jun 13, 2024
@StevenDufresne
Copy link
Contributor

@jonathanbossenger I updated the code block language on the code block in the lesson plan and it looks like its working.

Is there something different expected?

Settings After Save
Screenshot 2024-06-25 at 12 42 13 PM Screenshot 2024-06-25 at 12 49 13 PM

Video: https://d.pr/i/Ztmy5K

@jonathanbossenger
Copy link
Collaborator

Ah, my apologies folks, I was confusing the ability to highlight lines of code within the code block (which we don't have), with the ability to show syntax highlighting for specific languages, which we do have.

Thanks for picking this up @StevenDufresne, I'll make a note to update the code snippets in that course, and then close this ticket once that's done.

@jonathanbossenger jonathanbossenger added [Component] Content Website development issues related to the content on Learn. and removed [Component] Learn Theme Website development issues related to the Learn theme. Dev labels Jul 8, 2024
@jonathanbossenger jonathanbossenger removed this from the Learning Pathways launch milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Website development issues related to the content on Learn. [Content] Feedback Feedback provided about content on Learn.
4 participants