Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wp_create_file_in_uploads hook should change from an action hook to a filter hook #1139

Closed
nikkifurls opened this issue Oct 4, 2023 · 2 comments
Labels
[Status] Done Issue is completed

Comments

@nikkifurls
Copy link

Issue Description

Per https://core.trac.wordpress.org/ticket/57775, the wp_create_file_in_uploads hook is documented as an action hook, but should actually be a filter hook. As part of that ticket, we are changing instances where it is called with do_action to apply_filters, and the documentation should reflect that change as well.

URL of the Page with the Issue

https://developer.wordpress.org/reference/hooks/wp_create_file_in_uploads/

Why is this a problem?

This is a problem because once the change in https://core.trac.wordpress.org/ticket/57775 is committed, the documentation will be incorrect.

Suggested Fix

  • The code snippet needs to change from do_action to apply_filters
  • A return value section needs to be added
@nikkifurls nikkifurls added the [Status] To do Issue marked as Todo label Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Heads up @WordPress/docs-issues-coordinators, we have a new issue open. Time to use 'em labels.

@nikkifurls
Copy link
Author

Closing per @SergeyBiryukov in https://core.trac.wordpress.org/ticket/57775#comment:12:

As far as I can tell, the docs issue is not necessary here, the documentation will be updated automatically as soon as 6.4 is released and the DevHub code reference parser is run as part of the post-release tasks.

@github-actions github-actions bot added [Status] Done Issue is completed and removed [Status] To do Issue marked as Todo labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Done Issue is completed
1 participant