Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genius annotations blocked #713

Open
terrorist96 opened this issue Dec 19, 2015 · 3 comments
Open

Genius annotations blocked #713

terrorist96 opened this issue Dec 19, 2015 · 3 comments
Labels
broken site DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage

Comments

@terrorist96
Copy link
Contributor

assets.genius.com and genius.codes need to be yellow and genius.com needs to be green, otherwise you can't log into your genius account and make annotations.

genius.com and assets.genius.com and genius.codes need to be yellow if you simply want to view the annotations of others.

This is a good candidate for the disqus-type-pop up asking if you're okay with being tracked, etc.

https://www.washingtonpost.com/news/the-fix/wp/2015/12/15/who-said-what-and-what-it-meant-the-fifth-gop-debate-annotated/

bold = edit
@terrorist96
Copy link
Contributor Author

#400 ?
@ghostwords
Copy link
Member

ghostwords commented Dec 13, 2016 •
edited
Loading

I believe this is a job for #910.
@ghostwords
Copy link
Member

ghostwords commented Jun 21, 2017 •
edited
Loading

Ah OK, Genius here provides a set of third-party widgets to supply annotations/comments.

If Genius were able and willing to adopt the EFF Do Not Track policy, posting the policy on their domains would tell Privacy Badger to allow loading of resources from those domains.

In the meantime, I agree, the ideal workaround would be an in-page notification asking Privacy Badger users whether they want to see Genius annotations just this once (or always) on this site. This would require expansion of our existing widget replacement system. Embedded Tweets is a related issue: #1393.

In the short term, we should probably add genius.com and genius.codes to the yellowlist.
@ghostwords ghostwords added the DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy label Jun 21, 2017
@ghostwords ghostwords added the widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets label Jul 2, 2017
@ghostwords ghostwords added yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage and removed help wanted important labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken site DNT policy EFF's Do Not Track policy: www.eff.org/dnt-policy widgets Click-to-activate placeholders for blocked but potentially useful social buttons/widgets yellowlist Domains on this list are allowed but with restrictions: no referrer headers or cookies/localStorage
3 participants
@cooperq @ghostwords @terrorist96