Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send snitch_map with error reports #1901

Closed
bcyphers opened this issue Mar 2, 2018 · 2 comments
Closed

Send snitch_map with error reports #1901

bcyphers opened this issue Mar 2, 2018 · 2 comments

Comments

@bcyphers
Copy link
Contributor

bcyphers commented Mar 2, 2018

Sometimes it's hard to tell from error reports alone which hosts are causing certain 3rd-party domains to be blocked (e.g. #1880, #1882, #1883). When a user reports that a page is broken, PB could include snitch maps for all blocked domains on the page.

@ghostwords
Copy link
Member

ghostwords commented Mar 31, 2018

This conflicts with the protection from local/unsophisticated attackers goal of #266.

If we dropped snitch_map entries for domains that Privacy Badger already decided to block, we'd have no data to share.

If we obfuscated (one-way, per-user-salted hashes) the domains (leaving debugging aside, Privacy Badger just needs to know when it saw a domain track across three different website domains, not what those domains are), we'd have useless (don't know the user salt) data.

@ghostwords
Copy link
Member

This is sort of related to #1299.

I think whenever it's a mystery, it's probably one of our mis-attribution bugs (probably #1997).

Having snitch_map data would indeed be helpful, but I don't think we need it. We already mostly know what needs fixing, plus error reports continue to trend down. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment