Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling Privacy Badger based on site URL param #1843

Open
charmarkk opened this issue Jan 24, 2018 · 7 comments
Open

Disabling Privacy Badger based on site URL param #1843

charmarkk opened this issue Jan 24, 2018 · 7 comments
Labels
enhancement help wanted ui User interface modifications; related to but not the same as the "ux" label

Comments

@charmarkk
Copy link

I'd love to have an option to whitelist based on part of a URL or parameter. As it is, I can only whitelist a domain. For example, I whitelist several YouTube creators to allow ads on their videos with uBlock using a script/extension and a specific param, but they still get blocked by PB. I don't want to disable PB on YouTube as a whole, nor do I want to allow ads on every video. If there is there a way to do this currently, please disregard.

I've got an image of what my modified URL for uBlock looks like.
image

@ghostwords
Copy link
Member

ghostwords commented Jan 24, 2018

You could whitelist all subdomains of a domain (#624), but that doesn't seem to help here.

We should be mindful of performance (#1507) when revising isPrivacyBadgerEnabled() as it gets called frequently in performance-critical code paths. It might make sense to implement this specifically as a way to whitelist individual YouTube channels (friendlier UI, little performance impact outside of YouTube), as opposed to supporting querystring-based pattern matching in general.

As noted above, uBlock Origin allows whitelisting individual YouTube channels with the help of userscripts: https://github.com/gorhill/uBlock/wiki/How-to-whitelist-a-web-site#a-youtube-channel.

AdBlock seems to have this functionality built in: https://help.getadblock.com/support/solutions/articles/6000067131-how-do-i-whitelist-a-specific-youtube-channel-.

@ghostwords ghostwords added enhancement help wanted ui User interface modifications; related to but not the same as the "ux" label labels Jan 24, 2018
@alexristich

This comment has been minimized.

@ghostwords

This comment has been minimized.

@alexristich

This comment has been minimized.

@charmarkk

This comment has been minimized.

@ghostwords ghostwords self-assigned this Feb 19, 2018
@ghostwords ghostwords removed their assignment Sep 13, 2018
@iammyr
Copy link

iammyr commented Mar 3, 2019

I would like to have a look into implementing this, if there's interest

@fregante

This comment has been minimized.

@ghostwords ghostwords changed the title Whitelisting based on URL param Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted ui User interface modifications; related to but not the same as the "ux" label
5 participants