Changeset 58682

Timestamp:

07/06/2024 02:52:05 PM (4 weeks ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove obsolete comments about older PHP versions.

This commit:

• Removes various comments referencing PHP versions which are no longer supported.
• Removes various comments containing “hints” of things to do after a particular PHP version drop. These hints are incorrect/not actionable for various reasons, so have no value:
  • Even though a function could be turned into a closure, removing the function would be a backward compatibility break which is not acceptable, so this suggestion is not actionable.
  • Short ternaries are forbidden by the coding standard exactly to prevent the faulty code suggested in the comment from getting into the codebase.

Follow-up to [1243/tests], [6543], [11816], [29861], [29864], [34928], [35369], [36698], [38694], [50786], [58678].

Props jrf, ayeshrajans.
See #61574.

Location:

trunk

Files:

• src/wp-admin/includes/meta-boxes.php (modified) (1 diff)
• src/wp-includes/class-wp-customize-manager.php (modified) (1 diff)
• src/wp-includes/class-wp-object-cache.php (modified) (1 diff)
• src/wp-includes/http.php (modified) (1 diff)
• src/wp-includes/load.php (modified) (1 diff)
• src/wp-includes/rest-api/class-wp-rest-request.php (modified) (1 diff)
• tests/phpunit/tests/formatting/escTextarea.php (modified) (1 diff)
• tests/phpunit/tests/formatting/wpHtmleditPre.php (modified) (1 diff)
• tests/phpunit/tests/formatting/wpRicheditPre.php (modified) (1 diff)
• tests/phpunit/tests/http/http.php (modified) (6 diffs)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -1271 +1271 @@
     }
 
-    $link_rel  = isset( $link->link_rel ) ? $link->link_rel : ''; // In PHP 5.3: $link_rel = $link->link_rel ?: '';
+    $link_rel  = isset( $link->link_rel ) ? $link->link_rel : '';
     $link_rels = preg_split( '/\s+/', $link_rel );
 

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -6142 +6142 @@
      * into a partial's render_callback so we cannot use get_custom_logo() as
      * the render_callback directly since it expects a blog ID as the first
-     * argument. When WP no longer supports PHP 5.3, this method can be removed
-     * in favor of an anonymous function.
+     * argument.
      *
      * @see WP_Customize_Manager::register_controls()

trunk/src/wp-includes/class-wp-object-cache.php

@@ -74 +74 @@
 
     /**
-     * Sets up object properties; PHP 5 style constructor.
+     * Sets up object properties.
      *
      * @since 2.0.8

trunk/src/wp-includes/http.php

@@ -700 +700 @@
  * across PHP versions.
  *
- * PHP 5.4.7 expanded parse_url()'s ability to handle non-absolute URLs, including
- * schemeless and relative URLs with "://" in the path. This function works around
- * those limitations providing a standard output on PHP 5.2~5.4+.
- *
- * Secondly, across various PHP versions, schemeless URLs containing a ":" in the query
- * are being handled inconsistently. This function works around those differences as well.
+ * Across various PHP versions, schemeless URLs containing a ":" in the query
+ * are being handled inconsistently. This function works around those differences.
  *
  * @since 4.4.0

trunk/src/wp-includes/load.php

@@ -453 +453 @@
 /**
  * Gets the time elapsed so far during this PHP script.
- *
- * Uses REQUEST_TIME_FLOAT that appeared in PHP 5.4.0.
  *
  * @since 5.8.0

trunk/src/wp-includes/rest-api/class-wp-rest-request.php

@@ -710 +710 @@
      *
      * Parses out URL-encoded bodies for request methods that aren't supported
-     * natively by PHP. In PHP 5.x, only POST has these parsed automatically.
+     * natively by PHP.
      *
      * @since 4.4.0

trunk/tests/phpunit/tests/formatting/escTextarea.php

@@ -13 +13 @@
 
     /*
-     * Only fails in PHP 5.4 onwards
      * @ticket 23688
      */

trunk/tests/phpunit/tests/formatting/wpHtmleditPre.php

@@ -14 +14 @@
 
     /*
-     * Only fails in PHP 5.4 onwards
      * @ticket 23688
      */

trunk/tests/phpunit/tests/formatting/wpRicheditPre.php

@@ -14 +14 @@
 
     /*
-     * Only fails in PHP 5.4 onwards
      * @ticket 23688
      */

trunk/tests/phpunit/tests/http/http.php

@@ -115 +115 @@
             ),
 
-            // < PHP 5.4.7: Schemeless URL.
+            // Schemeless URL.
             array(
                 '//example.com/path/',
@@ -139 +139 @@
             ),
 
-            // < PHP 5.4.7: Scheme separator in the URL.
+            // Scheme separator in the URL.
             array(
                 'http://example.com/http://example.net/',
@@ -150 +150 @@
             array( '/path/http://example.net/', array( 'path' => '/path/http://example.net/' ) ),
 
-            // < PHP 5.4.7: IPv6 literals in schemeless URLs are handled incorrectly.
+            // .
             array(
                 '//[::FFFF::127.0.0.1]/',
@@ -239 +239 @@
             array( self::FULL_TEST_URL, PHP_URL_FRAGMENT, 'anchor' ),
 
-            // < PHP 5.4.7: Schemeless URL.
+            // Schemeless URL.
             array( '//example.com/path/', PHP_URL_HOST, 'example.com' ),
             array( '//example.com/path/', PHP_URL_PATH, '/path/' ),
@@ -247 +247 @@
             array( 'http://example.com//path/', PHP_URL_PATH, '//path/' ),
 
-            // < PHP 5.4.7: Scheme separator in the URL.
+            // Scheme separator in the URL.
             array( 'http://example.com/http://example.net/', PHP_URL_HOST, 'example.com' ),
             array( 'http://example.com/http://example.net/', PHP_URL_PATH, '/http://example.net/' ),
@@ -253 +253 @@
             array( '/path/http://example.net/', PHP_URL_PATH, '/path/http://example.net/' ),
 
-            // < PHP 5.4.7: IPv6 literals in schemeless URLs are handled incorrectly.
+            // .
             array( '//[::FFFF::127.0.0.1]/', PHP_URL_HOST, '[::FFFF::127.0.0.1]' ),
             array( '//[::FFFF::127.0.0.1]/', PHP_URL_PATH, '/' ),