Changeset 58673

Timestamp:

07/04/2024 03:09:15 PM (5 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in WP_REST_Global_Styles_Revisions_Controller tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [56082].

See #61573.

File:

• trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php (modified) (2 diffs)

trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php

@@ -273 +273 @@
         // Global styles.
         $config = ( new WP_Theme_JSON( json_decode( $revision_expected_item->post_content, true ), 'custom' ) )->get_raw_data();
-        $this->assertEquals(
+        $this->assert(
             $config['settings'],
             $response_revision_item['settings'],
             'Check that the revision settings exist in the response.'
         );
-        $this->assertEquals(
+        $this->assert(
             $config['styles'],
             $response_revision_item['styles'],
@@ -372 +372 @@
 
         $this->assertCount( $this->total_revisions + 1, $data, 'Check that extra revision exist' );
-        $this->assertEquals( self::$second_admin_id, $data[0]['author'], 'Check that second author id returns expected value.' );
+        $this->assert( self::$second_admin_id, $data[0]['author'], 'Check that second author id returns expected value.' );
     }