Get WordPress

Make WordPress Core

Changeset 58611

Timestamp:
07/01/2024 07:17:07 PM (5 weeks ago)
Author:
desrosj
Message:

Build/Test Tools: Make use of new reusable workflows for 5.4.

This updates the 5.4 branch to utilize the new reusable workflows in trunk introduced in [58165].

This also includes backports for a some additional improvements and bug fixes that are necessary for the local development environment to continue working long term:

  • The image and platform properties for the mysql container have been updated to always prefer amd64 containers (#60822).
  • macos-13 is now pinned for MacOS jobs instead of macos-latest (#61340).
  • Migrating to Docker Compose V2 (#60901).
  • Removing the version property from docker-compose.yml (#59416).
  • Improvements to how artifacts and comments for Playground testing are generated.
  • Removing SVN related commands causing failures (#61216).
  • Updating the actions/github-scripts action to the latest version.
  • Cache the results of PHP_CodeSniffer runs (#49783).
  • Move the Memcached container into the Docker Compose config (#55700).
  • Improvements to the healthcheck command for the mysql container (#58867).
  • Skip some tests when not in the primary branch (#50401).

Merges [49264], [51673], [52179], [53552], [53895], [56464], [57918], [58157], [57124], [57125], [57249] to the 5.4 branch.

Props johnbillion, joemcgill, swissspidy, thelovekesh, narenin, mukesh27, JeffPaul, peterwilsoncc, zieladam, ockham, SergeyBiryukov, jorbin, Clorith, afragen, jrf.
See #49783, #58867, #61340, #60822, #61216, #60901, #61101, #59416, #59805, #61213.

Location:
branches/5.4
Files:
2 added
1 deleted
12 edited
1 moved

Legend:

Unmodified
Added
Removed

  • branches/5.4

  • branches/5.4/.github/workflows/coding-standards.yml

    r55521 r58611  
    4141  cancel-in-progress: true
    4242
     43
     44
     45
     46
    4347jobs:
    4448  # Runs PHP coding standards checks.
    45   #
    46   # Violations are reported inline with annotations.
    47   #
    48   # Performs the following steps:
    49   # - Checks out the repository.
    50   # - Sets up PHP.
    51   # - Logs debug information.
    52   # - Installs Composer dependencies (use cache if possible).
    53   # - Make Composer packages available globally.
    54   # - Logs PHP_CodeSniffer debug information.
    55   # - Runs PHPCS on the full codebase with warnings suppressed.
    56   # - Runs PHPCS on the `tests` directory without warnings suppressed.
    5749  phpcs:
    5850    name: PHP coding standards
    59     runs-on: ubuntu-latest
    60     timeout-minutes: 20
     51    uses: WordPress/wordpress-develop/.github/workflows/reusable-coding-standards-php.yml@trunk
     52    permissions:
     53      contents: read
    6154    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    62 
    63     steps:
    64       - name: Checkout repository
    65         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    66 
    67       - name: Set up PHP
    68         uses: shivammathur/setup-php@d30ad8b1843ace22e6698ab99bbafaa747b6bd0d # v2.24.0
    69         with:
    70           php-version: '7.3'
    71           coverage: none
    72           tools: composer, cs2pr
    73 
    74       - name: Log debug information
    75         run: |
    76           php --version
    77           composer --version
    78 
    79       - name: Install Composer dependencies
    80         uses: ramsey/composer-install@83af392bf5f031813d25e6fe4cd626cdba9a2df6 # v2.2.0
    81         with:
    82           composer-options: "--no-progress --no-ansi"
    83 
    84       - name: Make Composer packages available globally
    85         run: echo "${PWD}/vendor/bin" >> $GITHUB_PATH
    86 
    87       - name: Log PHPCS debug information
    88         run: phpcs -i
    89 
    90       - name: Run PHPCBF on all Core files
    91         run: phpcbf
    92 
    93       - name: Run PHPCS on all Core files
    94         run: phpcs -q -n --report=checkstyle | cs2pr
    95 
    96       - name: Check test suite files for warnings
    97         run: phpcs tests -q --report=checkstyle | cs2pr
     55    with:
     56      php-version: '7.3'
    9857
    9958  # Runs the JavaScript coding standards checks.
    100   #
    101   # JSHint violations are not currently reported inline with annotations.
    102   #
    103   # Performs the following steps:
    104   # - Checks out the repository.
    105   # - Logs debug information about the GitHub Action runner.
    106   # - Installs Node.js.
    107   # - Logs updated debug information.
    108   # _ Installs npm dependencies.
    109   # - Run the WordPress JSHint checks.
    11059  jshint:
    11160    name: JavaScript coding standards
    112     runs-on: ubuntu-latest
    113     timeout-minutes: 20
     61    uses: WordPress/wordpress-develop/.github/workflows/reusable-coding-standards-javascript.yml@trunk
     62    permissions:
     63      contents: read
    11464    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    115     env:
    116       PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    117 
    118     steps:
    119       - name: Checkout repository
    120         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    121 
    122       - name: Log debug information
    123         run: |
    124           npm --version
    125           node --version
    126           git --version
    127           svn --version
    128 
    129       - name: Install Node.js
    130         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    131         with:
    132           node-version-file: '.nvmrc'
    133           cache: npm
    134 
    135       - name: Log debug information
    136         run: |
    137           npm --version
    138           node --version
    139 
    140       - name: Install Dependencies
    141         run: npm ci
    142 
    143       - name: Run JSHint
    144         run: npm run grunt jshint
    14565
    14666  slack-notifications:
    14767    name: Slack Notifications
    14868    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     69
     70
     71
    14972    needs: [ phpcs, jshint ]
    15073    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    … …  
    16083    name: Failed workflow tasks
    16184    runs-on: ubuntu-latest
     85
     86
    16287    needs: [ phpcs, jshint, slack-notifications ]
    16388    if: |
    … …  
    17398    steps:
    17499      - name: Dispatch workflow run
    175         uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     100        uses: actions/github-script@
    176101        with:
    177102          retries: 2

  • branches/5.4/.github/workflows/javascript-tests.yml

    r55521 r58611  
    3939  cancel-in-progress: true
    4040
     41
     42
     43
     44
    4145jobs:
    4246  # Runs the QUnit tests for WordPress.
    43   #
    44   # Performs the following steps:
    45   # - Checks out the repository.
    46   # - Logs debug information about the GitHub Action runner.
    47   # - Installs Node.js.
    48   # - Logs updated debug information.
    49   # _ Installs npm dependencies.
    50   # - Run the WordPress QUnit tests.
    5147  test-js:
    5248    name: QUnit Tests
    53     runs-on: ubuntu-latest
    54     timeout-minutes: 20
     49    uses: WordPress/wordpress-develop/.github/workflows/reusable-javascript-tests.yml@trunk
     50    permissions:
     51      contents: read
    5552    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    56 
    57     steps:
    58       - name: Checkout repository
    59         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    60 
    61       - name: Log debug information
    62         run: |
    63           npm --version
    64           node --version
    65           git --version
    66           svn --version
    67 
    68       - name: Set up Node.js
    69         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    70         with:
    71           node-version-file: '.nvmrc'
    72           cache: npm
    73 
    74       - name: Log debug information
    75         run: |
    76           npm --version
    77           node --version
    78 
    79       - name: Install Dependencies
    80         run: npm ci
    81 
    82       - name: Run QUnit tests
    83         run: npm run grunt qunit:compiled
    8453
    8554  slack-notifications:
    8655    name: Slack Notifications
    8756    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     57
     58
     59
    8860    needs: [ test-js ]
    8961    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    … …  
    9971    name: Failed workflow tasks
    10072    runs-on: ubuntu-latest
     73
     74
    10175    needs: [ test-js, slack-notifications ]
    10276    if: |
    … …  
    11185    steps:
    11286      - name: Dispatch workflow run
    113         uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     87        uses: actions/github-script@
    11488        with:
    11589          retries: 2

  • branches/5.4/.github/workflows/phpunit-tests.yml

    r55521 r58611  
    2727  cancel-in-progress: true
    2828
    29 env:
    30   PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    31   # Controls which npm script to use for running PHPUnit tests. Options ar `php` and `php-composer`.
    32   PHPUNIT_SCRIPT: php
    33   LOCAL_PHP_MEMCACHED: ${{ false }}
    34   SLOW_TESTS: 'external-http,media,restapi'
     29# Disable permissions for all available scopes by default.
     30# Any needed permissions should be configured at the job level.
     31permissions: {}
    3532
    3633jobs:
    37   # Runs the PHPUnit tests for WordPress.
    38   #
    39   # Performs the following steps:
    40   # - Sets environment variables.
    41   # - Sets up the environment variables needed for testing with memcached (if desired).
    42   # - Installs Node.js.
    43   # - Installs npm dependencies
    44   # - Configures caching for Composer.
    45   # - Installs Composer dependencies.
    46   # - Logs Docker debug information (about the Docker installation within the runner).
    47   # - Starts the WordPress Docker container.
    48   # - Starts the Memcached server after the Docker network has been created (if desired).
    49   # - Logs general debug information about the runner.
    50   # - Logs the running Docker containers.
    51   # - Logs debug information from inside the WordPress Docker container.
    52   # - Logs debug information about what's installed within the WordPress Docker containers.
    53   # - Install WordPress within the Docker container.
    54   # - Run the PHPUnit tests.
    55   # - Checks out the WordPress Test reporter repository.
    56   # - Reconnect the directory to the Git repository.
    57   # - Submit the test results to the WordPress.org host test results.
     34  # Creates PHPUnit test jobs.
    5835  test-php:
    59     name: ${{ matrix.php }}${{ matrix.multisite && ' multisite' || '' }}${{ matrix.split_slow && ' slow tests' || '' }}${{ matrix.memcached && ' with memcached' || '' }} on ${{ matrix.os }}
    60     runs-on: ${{ matrix.os }}
    61     timeout-minutes: 20
     36    name: PHP ${{ matrix.php }}
     37    uses: WordPress/wordpress-develop/.github/workflows/reusable-phpunit-tests-v2.yml@trunk
     38    permissions:
     39      contents: read
     40    secrets: inherit
    6241    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    6342    strategy:
    6443      fail-fast: false
    6544      matrix:
     45
    6646        php: [ '5.6', '7.0', '7.1', '7.2', '7.3', '7.4' ]
    67         os: [ ubuntu-latest ]
     47        multisite: [ false, true ]
     48        split_slow: [ false ]
    6849        memcached: [ false ]
    69         split_slow: [ false ]
    70         multisite: [ false, true ]
    7150        include:
    7251          # Additional "slow" jobs for PHP 5.6.
    73           - php: '5.6.20'
     52          - php: '5.6'
    7453            os: ubuntu-latest
    7554            memcached: false
    7655            multisite: false
    7756            split_slow: true
    78           - php: '5.6.20'
     57          - php: '5.6'
    7958            os: ubuntu-latest
    8059            memcached: false
    … …  
    8665            memcached: true
    8766            multisite: false
     67
    8868          - php: '7.4'
    8969            os: ubuntu-latest
    9070            memcached: true
    9171            multisite: true
    92           # Report the results of the PHP 7.4 without memcached job.
    93           - php: '7.4'
    94             os: ubuntu-latest
    95             memcached: false
    96             multisite: false
    97             report: true
    98     env:
    99       LOCAL_PHP: ${{ matrix.php }}-fpm
    100       LOCAL_PHP_MEMCACHED: ${{ matrix.memcached }}
    101       PHPUNIT_CONFIG: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
    102 
    103     steps:
    104       - name: Configure environment variables
    105         run: |
    106           echo "PHP_FPM_UID=$(id -u)" >> $GITHUB_ENV
    107           echo "PHP_FPM_GID=$(id -g)" >> $GITHUB_ENV
    108 
    109       - name: Checkout repository
    110         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    111 
    112       - name: Install Node.js
    113         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    114         with:
    115           node-version-file: '.nvmrc'
    116           cache: npm
    117 
    118 
    119       - name: Install npm dependencies
    120         run: npm ci
    121 
    122       - name: Get Composer cache directory
    123         id: composer-cache
    124         run: echo "composer_dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
    125 
    126       - name: Cache Composer dependencies
    127         uses: actions/cache@58c146cc91c5b9e778e71775dfe9bf1442ad9a12 # v3.2.3
    128         env:
    129           cache-name: cache-composer-dependencies
    130         with:
    131           path: ${{ steps.composer-cache.outputs.composer_dir }}
    132           key: ${{ runner.os }}-php-${{ matrix.php }}-composer-${{ hashFiles('**/composer.lock') }}
    133 
    134       - name: Install Composer dependencies
    135         run: |
    136           if [ ${{ env.LOCAL_PHP }} == '7.1-fpm' ]; then
    137             docker-compose run --rm php composer update
    138             git checkout -- composer.lock
    139           elif [[ ${{ env.LOCAL_PHP }} == '5.6.20-fpm' || ${{ env.LOCAL_PHP }} == '5.6-fpm' || ${{ env.LOCAL_PHP }} == '7.0-fpm' ]]; then
    140             docker-compose run --rm php composer require --dev phpunit/phpunit:"^5.7" --update-with-dependencies
    141             git checkout -- composer.lock composer.json
    142           else
    143             docker-compose run --rm php composer install
    144           fi
    145 
    146       - name: Docker debug information
    147         run: |
    148           docker -v
    149           docker-compose -v
    150 
    151       - name: Start Docker environment
    152         run: |
    153           npm run env:start
    154 
    155       # The memcached server needs to start after the Docker network has been set up with `npm run env:start`.
    156       - name: Start the Memcached server.
    157         if: ${{ matrix.memcached }}
    158         run: |
    159           cp tests/phpunit/includes/object-cache.php src/wp-content/object-cache.php
    160           docker run --name memcached --net $(basename "$PWD")_wpdevnet -d memcached
    161 
    162       - name: General debug information
    163         run: |
    164           npm --version
    165           node --version
    166           curl --version
    167           git --version
    168           svn --version
    169 
    170       - name: Log running Docker containers
    171         run: docker ps -a
    172 
    173       - name: WordPress Docker container debug information
    174         run: |
    175           docker-compose run --rm mysql mysql --version
    176           docker-compose run --rm php php --version
    177           docker-compose run --rm php php -m
    178           docker-compose run --rm php php -i
    179           docker-compose run --rm php locale -a
    180 
    181       - name: Install WordPress
    182         run: npm run env:install
    183 
    184       - name: Run slow PHPUnit tests
    185         if: ${{ matrix.split_slow }}
    186         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --group ${{ env.SLOW_TESTS }}
    187 
    188       - name: Run PHPUnit tests for single site excluding slow tests
    189         if: ${{ matrix.php < '7.0' && ! matrix.split_slow && ! matrix.multisite }}
    190         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --exclude-group ${{ env.SLOW_TESTS }},ajax,ms-files,ms-required
    191 
    192       - name: Run PHPUnit tests for Multisite excluding slow tests
    193         if: ${{ matrix.php < '7.0' && ! matrix.split_slow && matrix.multisite }}
    194         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --exclude-group ${{ env.SLOW_TESTS }},ajax,ms-files,ms-excluded,oembed-headers
    195 
    196       - name: Run PHPUnit tests
    197         if: ${{ matrix.php >= '7.0' }}
    198         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }}
    199 
    200       - name: Run AJAX tests
    201         if: ${{ ! matrix.split_slow && ! matrix.multisite }}
    202         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c ${{ env.PHPUNIT_CONFIG }} --group ajax
    203 
    204       - name: Run ms-files tests as a multisite install
    205         if: ${{ matrix.multisite && ! matrix.split_slow }}
    206         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c tests/phpunit/multisite.xml --group ms-files
    207 
    208       - name: Run external HTTP tests
    209         if: ${{ ! matrix.multisite && ! matrix.split_slow }}
    210         run: npm run test:${{ env.PHPUNIT_SCRIPT }} -- --verbose -c phpunit.xml.dist --group external-http
    211 
    212       # __fakegroup__ is excluded to force PHPUnit to ignore the <exclude> settings in phpunit.xml.dist.
    213       - name: Run (xDebug) tests
    214         if: ${{ ! matrix.split_slow }}
    215         run: LOCAL_PHP_XDEBUG=true npm run test:${{ env.PHPUNIT_SCRIPT }} -- -v --group xdebug --exclude-group __fakegroup__
    216 
    217       - name: Checkout the WordPress Test Reporter
    218         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    219         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    220         with:
    221           repository: 'WordPress/phpunit-test-runner'
    222           path: 'test-runner'
    223 
    224       - name: Submit test results to the WordPress.org host test results
    225         if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    226         env:
    227           WPT_REPORT_API_KEY: "${{ secrets.WPT_REPORT_API_KEY }}"
    228         run: docker-compose run --rm -e WPT_REPORT_API_KEY -e WPT_PREPARE_DIR=/var/www -e WPT_TEST_DIR=/var/www php php test-runner/report.php
     72            split_slow: false
     73    with:
     74      os: ${{ matrix.os }}
     75      php: ${{ matrix.php }}
     76      multisite: ${{ matrix.multisite }}
     77      split_slow: ${{ matrix.split_slow }}
     78      test_ajax: ${{ ! matrix.multisite }}
     79      memcached: ${{ matrix.memcached }}
     80      phpunit-config: ${{ matrix.multisite && 'tests/phpunit/multisite.xml' || 'phpunit.xml.dist' }}
    22981
    23082  slack-notifications:
    23183    name: Slack Notifications
    23284    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
     85
     86
     87
    23388    needs: [ test-php ]
    23489    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    23590    with:
    236       calling_status: ${{ needs.test-php.result == 'success' && 'success' || needs.test-php.result == 'cancelled' && 'cancelled' || 'failure' }}
     91      calling_status: ${{ ' }}
    23792    secrets:
    23893      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    24499    name: Failed workflow tasks
    245100    runs-on: ubuntu-latest
    246     needs: [ test-php, slack-notifications ]
     101    permissions:
     102      actions: write
     103    needs: [ slack-notifications ]
    247104    if: |
    248105      always() &&
    … …  
    251108      github.run_attempt < 2 &&
    252109      (
    253         needs.test-php.result == 'cancelled' || needs.test-php.result == 'failure'
     110        contains( needs.*.result, 'cancelled' ) ||
     111        contains( needs.*.result, 'failure' )
    254112      )
    255113
    256114    steps:
    257115      - name: Dispatch workflow run
    258         uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     116        uses: actions/github-script@
    259117        with:
    260118          retries: 2

  • branches/5.4/.github/workflows/test-build-processes.yml

    r58610 r58611  
    1 name: Test npm
     1name: Test
    22
    33on:
    … …  
    3434  cancel-in-progress: true
    3535
    36 env:
    37   PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
     36# Disable permissions for all available scopes by default.
     37# Any needed permissions should be configured at the job level.
     38permissions: {}
    3839
    3940jobs:
    40   # Verifies that installing npm dependencies and building WordPress works as expected.
    41   #
    42   # Performs the following steps:
    43   # - Checks out the repository.
    44   # - Logs debug information about the GitHub Action runner.
    45   # - Installs Node.js.
    46   # _ Installs npm dependencies.
    47   # - Builds WordPress to run from the `build` directory.
    48   # - Cleans up after building WordPress to the `build` directory.
    49   # - Builds WordPress to run from the `src` directory.
    50   # - Cleans up after building WordPress to the `src` directory.
    51   test-npm:
    52     name: Test npm on ${{ matrix.os }}
    53     runs-on: ${{ matrix.os }}
    54     timeout-minutes: 20
     41  # Tests the WordPress Core build process on multiple operating systems.
     42  test-core-build-process:
     43    name: Core running from ${{ matrix.directory }}
     44    uses: WordPress/wordpress-develop/.github/workflows/reusable-test-core-build-process.yml@trunk
     45    permissions:
     46      contents: read
    5547    if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
    5648    strategy:
    … …  
    5850      matrix:
    5951        os: [ ubuntu-latest, windows-latest ]
     52
     53
     54
     55
     56
     57
     58
     59
     60
     61
     62
    6063
    61     steps:
    62       - name: Checkout repository
    63         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    64 
    65       - name: Log debug information
    66         run: |
    67           npm --version
    68           node --version
    69           curl --version
    70           git --version
    71           svn --version
    72 
    73       - name: Install Node.js
    74         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    75         with:
    76           node-version-file: '.nvmrc'
    77           cache: npm
    78 
    79       - name: Install Dependencies
    80         run: npm ci
    81 
    82       - name: Build WordPress
    83         run: npm run build
    84 
    85       - name: Clean after building
    86         run: npm run grunt clean
    87 
    88       - name: Build WordPress in /src
    89         run: npm run build:dev
    90 
    91       - name: Clean after building in /src
    92         run: npm run grunt clean -- --dev
    93 
    94   # Verifies that installing npm dependencies and building WordPress works as expected on MacOS.
     64  # Tests the WordPress Core build process on MacOS.
    9565  #
    96   # This is separate from the job above in order to use stricter conditions about when to run.
     66  # This is separate from the job above in order to use stricter conditions when to run.
    9767  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
    9868  #
    … …  
    10070  # currently no way to determine the OS being used on a given job.
    10171  # See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability.
    102   #
    103   # Performs the following steps:
    104   # - Checks out the repository.
    105   # - Logs debug information about the GitHub Action runner.
    106   # - Installs Node.js.
    107   # _ Installs npm dependencies.
    108   # - Builds WordPress to run from the `build` directory.
    109   # - Cleans up after building WordPress to the `build` directory.
    110   # - Builds WordPress to run from the `src` directory.
    111   # - Cleans up after building WordPress to the `src` directory.
    112   test-npm-macos:
    113     name: Test npm on MacOS
    114     runs-on: macos-latest
    115     timeout-minutes: 30
     72  test-core-build-process-macos:
     73    name: Core running from ${{ matrix.directory }}
     74    uses: WordPress/wordpress-develop/.github/workflows/reusable-test-core-build-process.yml@trunk
     75    permissions:
     76      contents: read
    11677    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    117     steps:
    118       - name: Checkout repository
    119         uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    120 
    121       - name: Log debug information
    122         run: |
    123           npm --version
    124           node --version
    125           curl --version
    126           git --version
    127           svn --version
    128 
    129       - name: Install Node.js
    130         uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    131         with:
    132           node-version-file: '.nvmrc'
    133           cache: npm
    134 
    135       - name: Install Dependencies
    136         run: npm ci
    137 
    138       - name: Build WordPress
    139         run: npm run build
    140 
    141       - name: Clean after building
    142         run: npm run grunt clean
    143 
    144       - name: Build WordPress in /src
    145         run: npm run build:dev
    146 
    147       - name: Clean after building in /src
    148         run: npm run grunt clean -- --dev
     78    strategy:
     79      fail-fast: false
     80      matrix:
     81        os: [ macos-13 ]
     82        directory: [ 'src', 'build' ]
     83    with:
     84      os: ${{ matrix.os }}
     85      directory: ${{ matrix.directory }}
     86      test-emoji: false
    14987
    15088  slack-notifications:
    15189    name: Slack Notifications
    15290    uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
    153     needs: [ test-npm, test-npm-macos ]
     91    permissions:
     92      actions: read
     93      contents: read
     94    needs: [ test-core-build-process, test-core-build-process-macos ]
    15495    if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
    15596    with:
    156       calling_status: ${{ needs.test-npm.result == 'success' && needs.test-npm-macos.result == 'success' && 'success' || ( needs.test-npm.result == 'cancelled' || needs.test-npm-macos.result == 'cancelled' ) && 'cancelled' || 'failure' }}
     97      calling_status: ${{ ' }}
    15798    secrets:
    15899      SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
    … …  
    164105    name: Failed workflow tasks
    165106    runs-on: ubuntu-latest
    166     needs: [ test-npm, test-npm-macos, slack-notifications ]
     107    permissions:
     108      actions: write
     109    needs: [ slack-notifications ]
    167110    if: |
    168111      always() &&
    … …  
    171114      github.run_attempt < 2 &&
    172115      (
    173         needs.test-npm.result == 'cancelled' || needs.test-npm.result == 'failure' ||
    174         needs.test-npm-macos.result == 'cancelled' || needs.test-npm-macos.result == 'failure'
     116        ||
     117       
    175118      )
    176119
    177120    steps:
    178121      - name: Dispatch workflow run
    179         uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     122        uses: actions/github-script@
    180123        with:
    181124          retries: 2

  • branches/5.4/.gitignore

    r47352 r58611  
    1010/.phpcs.xml
    1111/phpcs.xml
     12
    1213/tests/phpunit/data/plugins/wordpress-importer
    1314/tests/phpunit/data/.trac-ticket-cache*

  • branches/5.4/docker-compose.yml

    r55521 r58611  
    1 version: '3.7'
    2 
    31services:
    42
    … …  
    2220      - ./:/var/www
    2321
    24     # Load our config file, substituning environment variables into the config.
     22    # Load our config file, substituing environment variables into the config.
    2523    command: /bin/sh -c "envsubst '$$LOCAL_DIR' < /etc/nginx/conf.d/default.template > /etc/nginx/conf.d/default.conf && exec nginx -g 'daemon off;'"
    2624
    2725    depends_on:
    28       - php
     26      php:
     27        condition: service_started
     28      mysql:
     29        condition: service_healthy
    2930
    3031  ##
    … …  
    3839
    3940    environment:
    40       LOCAL_PHP_XDEBUG: ${LOCAL_PHP_XDEBUG-false}
    41       LOCAL_PHP_MEMCACHED: ${LOCAL_PHP_MEMCACHED-false}
    42       PHP_FPM_UID: ${PHP_FPM_UID-1000}
    43       PHP_FPM_GID: ${PHP_FPM_GID-1000}
     41      - LOCAL_PHP_XDEBUG=${LOCAL_PHP_XDEBUG-false}
     42      - XDEBUG_MODE=${LOCAL_PHP_XDEBUG_MODE-develop,debug}
     43      - LOCAL_PHP_MEMCACHED=${LOCAL_PHP_MEMCACHED-false}
     44      - PHP_FPM_UID=${PHP_FPM_UID-1000}
     45      - PHP_FPM_GID=${PHP_FPM_GID-1000}
     46      - GITHUB_REF=${GITHUB_REF-false}
     47      - GITHUB_EVENT_NAME=${GITHUB_EVENT_NAME-false}
    4448
    4549    volumes:
    … …  
    4751      - ./:/var/www
    4852
    49     depends_on:
    50       - mysql
     53    # Copy or delete the Memcached dropin plugin file as appropriate.
     54    command: /bin/sh -c "if [ $LOCAL_PHP_MEMCACHED = true ]; then cp -n /var/www/tests/phpunit/includes/object-cache.php /var/www/src/wp-content/object-cache.php; else rm -f /var/www/src/wp-content/object-cache.php; fi && exec php-fpm"
     55
     56    # The init directive ensures the command runs with a PID > 1, so Ctrl+C works correctly.
     57    init: true
     58
     59    extra_hosts:
     60      - localhost:host-gateway
    5161
    5262  ##
    … …  
    5464  ##
    5565  mysql:
    56     image: amd64/${LOCAL_DB_TYPE-mysql}:${LOCAL_DB_VERSION-latest}
     66    image: ${LOCAL_DB_TYPE-mysql}:${LOCAL_DB_VERSION-latest}
     67    platform: linux/amd64
    5768
    5869    networks:
    … …  
    7283    command: --default-authentication-plugin=mysql_native_password
    7384
     85
     86
     87
     88
     89
     90
    7491  ##
    7592  # The WP CLI container.
    … …  
    8299
    83100    environment:
    84       LOCAL_PHP_XDEBUG: ${LOCAL_PHP_XDEBUG-false}
    85       LOCAL_PHP_MEMCACHED: ${LOCAL_PHP_MEMCACHED-false}
    86       PHP_FPM_UID: ${PHP_FPM_UID-1000}
    87       PHP_FPM_GID: ${PHP_FPM_GID-1000}
     101      ${LOCAL_PHP_XDEBUG-false}
     102      ${LOCAL_PHP_MEMCACHED-false}
     103      ${PHP_FPM_UID-1000}
     104      ${PHP_FPM_GID-1000}
    88105
    89106    volumes:
    … …  
    92109    # The init directive ensures the command runs with a PID > 1, so Ctrl+C works correctly.
    93110    init: true
     111
     112
     113
     114
     115
     116
     117
     118
     119
    94120
    95121  ##
    … …  
    103129
    104130    environment:
    105       LOCAL_PHP_XDEBUG: ${LOCAL_PHP_XDEBUG-false}
    106       LOCAL_PHP_MEMCACHED: ${LOCAL_PHP_MEMCACHED-false}
    107       LOCAL_DIR: ${LOCAL_DIR-src}
    108       WP_MULTISITE: ${WP_MULTISITE-false}
    109       PHP_FPM_UID: ${PHP_FPM_UID-1000}
    110       PHP_FPM_GID: ${PHP_FPM_GID-1000}
    111       TRAVIS_BRANCH: ${TRAVIS_BRANCH-false}
    112       TRAVIS_PULL_REQUEST: ${TRAVIS_PULL_REQUEST-false}
     131      ${LOCAL_PHP_XDEBUG-false}
     132      ${LOCAL_PHP_MEMCACHED-false}
     133      }
     134      }
     135      }
     136      }
     137      -false}
     138      -false}
    113139
    114140    volumes:
    … …  
    121147
    122148    depends_on:
    123       - mysql
     149      php:
     150        condition: service_started
     151      mysql:
     152        condition: service_healthy
     153
     154  ##
     155  # The Memcached container.
     156  ##
     157  memcached:
     158    image: memcached
     159
     160    networks:
     161      - wpdevnet
     162
     163    ports:
     164      - 11211:11211
     165
     166    depends_on:
     167      php:
     168        condition: service_started
    124169
    125170volumes:

  • branches/5.4/phpcompat.xml.dist

    r47122 r58611  
    1212
    1313    <!-- Whenever possible, cache the scan results and re-use those for unchanged files on the next scan. -->
    14     <arg name="cache"/>
     14    <arg name="cache"/>
    1515
    1616    <!-- Set the memory limit to 256M.

  • branches/5.4/phpcs.xml.dist

    r47207 r58611  
    77
    88    <!-- Whenever possible, cache the scan results and re-use those for unchanged files on the next scan. -->
    9     <arg name="cache"/>
     9    <arg name="cache"/>
    1010
    1111    <!-- Set the memory limit to 256M.

  • branches/5.4/tests/phpunit/includes/abstract-testcase.php

    r50604 r58611  
    181181
    182182    /**
    183      * Allow tests to be skipped on some automated runs.
    184      *
    185      * For test runs on Travis for something other than trunk/master
    186      * we want to skip tests that only need to run for master.
     183     * Allow tests to be skipped on some automated runs.
     184     *
     185     * For test runs on
     186     * we want to skip tests that only need to run for .
    187187     */
    188188    public function skipOnAutomatedBranches() {
    189         // https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables
    190         $travis_branch       = getenv( 'TRAVIS_BRANCH' );
    191         $travis_pull_request = getenv( 'TRAVIS_PULL_REQUEST' );
    192 
    193         if ( ! $travis_branch || ! $travis_pull_request ) {
    194             return;
    195         }
    196 
    197         if ( 'master' !== $travis_branch || 'false' !== $travis_pull_request ) {
    198             $this->markTestSkipped( 'For automated test runs, this test is only run on trunk/master' );
     189        // https://docs.github.com/en/actions/learn-github-actions/environment-variables#default-environment-variables
     190        $github_event_name = getenv( 'GITHUB_EVENT_NAME' );
     191        $github_ref        = getenv( 'GITHUB_REF' );
     192
     193        if ( $github_event_name ) {
     194            // We're on GitHub Actions.
     195            $skipped = array( 'pull_request', 'pull_request_target' );
     196
     197            if ( in_array( $github_event_name, $skipped, true ) || 'refs/heads/trunk' !== $github_ref ) {
     198                $this->markTestSkipped( 'For automated test runs, this test is only run on trunk' );
     199            }
    199200        }
    200201    }

  • branches/5.4/tools/local-env/scripts/docker.js

    r49364 r58611  
    55dotenvExpand( dotenv.config() );
    66
    7 // Execute any docker-compose command passed to this script.
    8 execSync( 'docker-compose ' + process.argv.slice( 2 ).join( ' ' ), { stdio: 'inherit' } );
     7// Execute any dockercompose command passed to this script.
     8execSync( 'dockercompose ' + process.argv.slice( 2 ).join( ' ' ), { stdio: 'inherit' } );

  • branches/5.4/tools/local-env/scripts/install.js

    r50303 r58611  
    4545 */
    4646function wp_cli( cmd ) {
    47     execSync( `docker-compose run --rm cli ${cmd}`, { stdio: 'inherit' } );
     47    execSync( `dockercompose run --rm cli ${cmd}`, { stdio: 'inherit' } );
    4848}
    4949
    … …  
    5454    const test_plugin_directory = 'tests/phpunit/data/plugins/wordpress-importer';
    5555
    56     execSync( `docker-compose exec -T php rm -rf ${test_plugin_directory} && svn checkout -r ${process.env.WP_IMPORTER_REVISION} https://plugins.svn.wordpress.org/wordpress-importer/trunk/ ${test_plugin_directory}`, { stdio: 'inherit' } );
     56    execSync( `dockercompose exec -T php rm -rf ${test_plugin_directory} && svn checkout -r ${process.env.WP_IMPORTER_REVISION} https://plugins.svn.wordpress.org/wordpress-importer/trunk/ ${test_plugin_directory}`, { stdio: 'inherit' } );
    5757}

  • branches/5.4/tools/local-env/scripts/start.js

    r49364 r58611  
    66
    77// Start the local-env containers.
    8 execSync( 'docker-compose up -d wordpress-develop', { stdio: 'inherit' } );
     8const containers = ( process.env.LOCAL_PHP_MEMCACHED === 'true' )
     9    ? 'wordpress-develop memcached'
     10    : 'wordpress-develop';
     11execSync( `docker compose up -d ${containers}`, { stdio: 'inherit' } );
    912
    1013// If Docker Toolbox is being used, we need to manually forward LOCAL_PORT to the Docker VM.
Note: See TracChangeset for help on using the changeset viewer.