Changeset 58447

Timestamp:

06/20/2024 04:02:10 PM (7 weeks ago)

Author:

adamsilverstein

Message:

Media: improve titles when inserting via REST API.

Match the naming behavior for uploaded media in the REST API to the way media is named when uploading in the media library. Fix an issue where dashes were replacing spaces unnecessarily.

Props abitofmind, kadamwhite, spacedmonkey, adamsilverstein, audrasjb, hellofromTonya.
Fixes #57957.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -305 +305 @@
         $attachment->guid           = $url;
 
+
+
+
+
+
+
+
+
+
+
+
         if ( empty( $attachment->post_title ) ) {
             $attachment->post_title = preg_replace( '/\.[^.]+$/', '', wp_basename( $file ) );

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -2016 +2016 @@
 
     /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
      * Ensure the `rest_after_insert_attachment` and `rest_insert_attachment` hooks only fire
      * once when attachments are updated.