Changeset 58217

Timestamp:

05/27/2024 07:42:15 PM (2 months ago)

Author:

joedolson

Message:

Media: Add missing units for length and dimensions in media library.

Include explicit units for media length and dimensions in attachment modal and media details screen.

Props Presskopp, joedolson, shailu25, audrasjb.
Fixes #59009.

Location:

trunk/src

Files:

• wp-admin/includes/media.php (modified) (3 diffs)
• wp-includes/media-template.php (modified) (2 diffs)

trunk/src/wp-admin/includes/media.php

@@ -1665 +1665 @@
 
     if ( isset( $meta['width'], $meta['height'] ) ) {
-        $media_dims .= "<span id='media-dims-$post->ID'>{$meta['width']}&nbsp;&times;&nbsp;{$meta['height']}</span> ";
+        /* translators: 1: A number of pixels wide, 2: A number of pixels tall. */
+        $media_dims .= "<span id='media-dims-$post->ID'>" . sprintf( __( '%1$s by %2$s pixels' ), $meta['width'], $meta['height'] ) . '</span>';
     }
 
@@ -3307 +3308 @@
 
     if ( isset( $meta['width'], $meta['height'] ) ) {
-        $media_dims .= "<span id='media-dims-$attachment_id'>{$meta['width']}&nbsp;&times;&nbsp;{$meta['height']}</span> ";
+        /* translators: 1: A number of pixels wide, 2: A number of pixels tall. */
+        $media_dims .= "<span id='media-dims-$attachment_id'>" . sprintf( __( '%1$s by %2$s pixels' ), $meta['width'], $meta['height'] ) . '</span>';
     }
     /** This filter is documented in wp-admin/includes/media.php */
@@ -3442 +3444 @@
                         }
                         break;
+
+
+
                     default:
                         echo esc_html( $meta[ $key ] );

trunk/src/wp-includes/media-template.php

@@ -484 +484 @@
                 <# if ( data.fileLength && data.fileLengthHumanReadable ) { #>
                     <div class="file-length"><strong><?php _e( 'Length:' ); ?></strong>
-                        <span aria-hidden="true">{{ data.fileLength }}</span>
+                        <span aria-hidden="true">{{ data.fileLength }}</span>
                         <span class="screen-reader-text">{{ data.fileLengthHumanReadable }}</span>
                     </div>
@@ -730 +730 @@
                 <# if ( data.fileLength && data.fileLengthHumanReadable ) { #>
                     <div class="file-length"><?php _e( 'Length:' ); ?>
-                        <span aria-hidden="true">{{ data.fileLength }}</span>
+                        <span aria-hidden="true">{{ data.fileLength }}</span>
                         <span class="screen-reader-text">{{ data.fileLengthHumanReadable }}</span>
                     </div>