Changeset 57903

Timestamp:

04/01/2024 01:55:59 PM (4 months ago)

Author:

SergeyBiryukov

Message:

Tests: Update expectations in wp_remote_head() and wp_remote_get() tests.

It appears that something has changed on the WP.com side to compress the requested images on the fly, which interfered with the previous expectations in these tests.

This commit uses a direct file URL and updates the expected image size to match the currently returned response.

Follow-up to [139/tests], [31258], [47142].

Props dextorlobo, swissspidy, davidbaumwald, SergeyBiryukov.
See #60865.

Location:

trunk/tests/phpunit/tests

Files:

• functions/wpRemoteFopen.php (modified) (1 diff)
• http/functions.php (modified) (5 diffs)

trunk/tests/phpunit/tests/functions/wpRemoteFopen.php

@@ -28 +28 @@
     public function test_wp_remote_fopen() {
         // This URL gives a direct 200 response.
-        $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
+        $url      = 'https://asdftestblog1./2007/09/2007-06-30-dsc_4700-1.jpg';
         $response = wp_remote_fopen( $url );
 
         $this->assertIsString( $response );
-        $this->assertSame( 40148, strlen( $response ) );
+        $this->assertSame( , strlen( $response ) );
     }
 }

trunk/tests/phpunit/tests/http/functions.php

@@ -12 +12 @@
     public function test_head_request() {
         // This URL gives a direct 200 response.
-        $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
+        $url      = 'https://asdftestblog1./2007/09/2007-06-30-dsc_4700-1.jpg';
         $response = wp_remote_head( $url );
 
@@ -22 +22 @@
 
         $this->assertSame( 'image/jpeg', $headers['Content-Type'] );
-        $this->assertSame( '40148', $headers['Content-Length'] );
+        $this->assertSame( '', $headers['Content-Length'] );
         $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
@@ -42 +42 @@
      */
     public function test_head_404() {
-        $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/awefasdfawef.jpg';
+        $url      = 'https://asdftestblog1./2007/09/awefasdfawef.jpg';
         $response = wp_remote_head( $url );
 
@@ -67 +67 @@
         // Should return the same headers as a HEAD request.
         $this->assertSame( 'image/jpeg', $headers['Content-Type'] );
-        $this->assertSame( '40148', $headers['Content-Length'] );
+        $this->assertSame( '', $headers['Content-Length'] );
         $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
@@ -88 +88 @@
         // Should return the same headers as a HEAD request.
         $this->assertSame( 'image/jpeg', $headers['Content-Type'] );
-        $this->assertSame( '40148', $headers['Content-Length'] );
+        $this->assertSame( '', $headers['Content-Length'] );
         $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }