Changeset 57885

Timestamp:

03/27/2024 03:58:46 PM (4 months ago)

Author:

swissspidy

Message:

Editor: disable shadow.defaultPresets for classic themes.

With this change default shadow presets are never shown for classic themes, and classic themes have no options for adding custom ones.
This essentially reverts [57717] and [57827] / [57828], which had unintended consequences.

Props ajlende, oandregal, madhudollu, swissspidy, get_dave, andrewserong, desrosj.
Fixes #60815.

Location:

trunk

Files:

• src/wp-includes/class-wp-theme-json-resolver.php (modified) (1 diff)
• src/wp-includes/class-wp-theme-json.php (modified) (2 diffs)
• src/wp-includes/theme.json (modified) (1 diff)
• tests/phpunit/data/themedir1/block-theme/theme.json (modified) (1 diff)
• tests/phpunit/tests/theme/wpThemeJson.php (modified) (2 diffs)
• tests/phpunit/tests/theme/wpThemeJsonResolver.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-theme-json-resolver.php

@@ -312 +312 @@
             }
             $theme_support_data['settings']['color']['defaultGradients'] = $default_gradients;
+
+
+
+
+
+
+
+
+
+
+
 
             // Allow themes to enable link color setting via theme_support.

trunk/src/wp-includes/class-wp-theme-json.php

@@ -659 +659 @@
      * @since 6.2.0 Added `dimensions.minHeight` and `position.sticky`.
      * @since 6.4.0 Added `background.backgroundImage`.
-     * @since 6.5.0 Added `background.backgroundSize`, `dimensions.aspectRatio`, and `shadow.defaultPresets`.
+     * @since 6.5.0 Added `background.backgroundSize``.
      * @var array
      */
@@ -680 +680 @@
         array( 'spacing', 'padding' ),
         array( 'typography', 'lineHeight' ),
-        array( 'shadow', 'defaultPresets' ),
     );
 

trunk/src/wp-includes/theme.json

@@ -192 +192 @@
         },
         "shadow": {
-            "defaultPresets": false,
+            "defaultPresets": e,
             "presets": [
                 {

trunk/tests/phpunit/data/themedir1/block-theme/theme.json

@@ -49 +49 @@
             "padding": true,
             "blockGap": true
+
+
+
+
+
+
+
+
+
+
+
+
+
+
         },
         "blocks": {

trunk/tests/phpunit/tests/theme/wpThemeJson.php

@@ -294 +294 @@
                 'lineHeight' => true,
             ),
-            'shadow'     => array(
-                'defaultPresets' => true,
-            ),
             'blocks'     => array(
                 'core/paragraph' => array(
@@ -334 +331 @@
                     'typography' => array(
                         'lineHeight' => false,
-                    ),
-                    'shadow'     => array(
-                        'defaultPresets' => true,
                     ),
                 ),

trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

@@ -202 +202 @@
                     'blockGap' => true,
                 ),
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
                 'blocks'     => array(
                     'core/paragraph' => array(
@@ -556 +572 @@
                             'slug' => 'custom',
                             'size' => '100px',
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
                         ),
                     ),
@@ -1071 +1103 @@
         );
     }
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 }