Changeset 57603

Timestamp:

02/12/2024 10:15:45 PM (6 months ago)

Author:

swissspidy

Message:

REST API: Add featured_media field to attachments endpoint.

Audio and video attachments can have a featured image, also known as a poster image. This functionality is now properly exposed by the wp/v2/media endpoint.

Props swissspidy, timothyblynjacobs, wonderboymusic, dlh, spacedmonkey.
Fixes #41692.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php (modified) (3 diffs)
• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• tests/phpunit/includes/testcase-rest-post-type-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-attachments-controller.php (modified) (3 diffs)
• tests/qunit/fixtures/wp-api-generated.js (modified) (4 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php

@@ -172 +172 @@
         }
 
+
+
+
+
+
+
+
+
         if ( ! empty( $schema['properties']['meta'] ) && isset( $request['meta'] ) ) {
             $meta_update = $this->meta->update_value( $request['meta'], $attachment_id );
@@ -324 +332 @@
 
     /**
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
      * Updates a single attachment.
      *
@@ -355 +400 @@
 
         $attachment = get_post( $request['id'] );
+
+
+
+
+
+
+
+
 
         $fields_update = $this->update_additional_fields_for_object( $attachment, $request );

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -2378 +2378 @@
                 'revisions',
                 'custom-fields',
+
             ),
         );

trunk/tests/phpunit/includes/testcase-rest-post-type-controller.php

@@ -78 +78 @@
         }
 
-        if ( post_type_supports( $post->post_type, 'thumbnail' ) ) {
+        if (
+            post_type_supports( $post->post_type, 'thumbnail' ) ||
+            (
+                'attachment' === $post->post_type &&
+                (
+                    post_type_supports( 'attachment:audio', 'thumbnail' ) ||
+                    post_type_supports( 'attachment:video', 'thumbnail' )
+                )
+            )
+        ) {
             $this->assertSame( (int) get_post_thumbnail_id( $post->ID ), $data['featured_media'] );
         } else {

trunk/tests/phpunit/tests/rest-api/rest-attachments-controller.php

@@ -1066 +1066 @@
         $term = wp_get_post_terms( $attachment['id'], 'category' );
         $this->assertSame( $category['term_id'], $term[0]->term_id );
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
     }
 
@@ -1577 +1648 @@
         $data       = $response->get_data();
         $properties = $data['schema']['properties'];
-        $this->assertCount( 27, $properties );
+        $this->assertCount( 2, $properties );
         $this->assertArrayHasKey( 'author', $properties );
         $this->assertArrayHasKey( 'alt_text', $properties );
@@ -1611 +1682 @@
         $this->assertArrayHasKey( 'type', $properties );
         $this->assertArrayHasKey( 'missing_image_sizes', $properties );
+
     }
 

trunk/tests/qunit/fixtures/wp-api-generated.js

@@ -7316 +7316 @@
                             "required": false
                         },
+
+
+
+
+
                         "comment_status": {
                             "description": "Whether or not comments are open on the post.",
@@ -7515 +7520 @@
                         "author": {
                             "description": "The ID for the author of the post.",
+
+
+
+
+
                             "type": "integer",
                             "required": false
@@ -12694 +12704 @@
         },
         "author": 0,
+
         "comment_status": "open",
         "ping_status": "closed",
@@ -12755 +12766 @@
     },
     "author": 0,
+
     "comment_status": "open",
     "ping_status": "closed",